refactor: remove BaseModule.ts and rename NonStaticBaseModule.ts to replace it.#512
Merged
mlodyjesienin merged 1 commit intomainfrom Aug 29, 2025
Merged
Conversation
Collaborator
|
lets wait with this until we implement the fix to llms and migrate them to JSI |
mlodyjesienin
force-pushed
the
@mlodyjesienin/refactor-basemodel
branch
from
66c4abc to
1b70898
Compare
mkopcins
approved these changes
Aug 29, 2025
mkopcins
pushed a commit
that referenced
this pull request
Sep 2, 2025
…eplace it. (#512) After the port to C++, the static `BaseModule` in typescript is no longer needed. Additionally `NonStaticBaseModule` can take its place and use simpler, less confusing name. This way, in most cases the class that inherits after `BaseModule` corresponds nicely with C++ class that inherits after `BaseModel` C++ class. The same reasoning could be made, and therefore was applied to hooks: `useModule` and `useNonStaticModule` - [ ] Yes - [x] No - [ ] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [x] Other (chores, tests, code style improvements etc.) - [x] iOS - [ ] Android <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> <!-- Add screenshots here, if applicable --> Closes #500 - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
KnextKoder
pushed a commit
to Synkhiv/react-native-executorch
that referenced
this pull request
Nov 7, 2025
…eplace it. (software-mansion#512) ## Description After the port to C++, the static `BaseModule` in typescript is no longer needed. Additionally `NonStaticBaseModule` can take its place and use simpler, less confusing name. This way, in most cases the class that inherits after `BaseModule` corresponds nicely with C++ class that inherits after `BaseModel` C++ class. The same reasoning could be made, and therefore was applied to hooks: `useModule` and `useNonStaticModule` ### Introduces a breaking change? - [ ] Yes - [x] No ### Type of change - [ ] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [x] Other (chores, tests, code style improvements etc.) ### Tested on - [x] iOS - [ ] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues Closes software-mansion#500 ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the (almost full) port to C++, the static
BaseModulein typescript is no longer needed.Additionally
NonStaticBaseModulecan take its place and use simpler, less confusing name.This way, in most cases the class that inherits after
BaseModulecorresponds nicely with C++ class that inherits afterBaseModelC++ class.The same reasoning could be made, and therefore was applied to hooks:
useModuleanduseNonStaticModuleIntroduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Closes #500
Checklist
Additional notes