Fix: release mode on IOS files fetching not working#567
Merged
mlodyjesienin merged 2 commits intomainfrom Aug 28, 2025
Merged
Conversation
jakmro
approved these changes
Aug 28, 2025
mlodyjesienin
added a commit
that referenced
this pull request
Aug 28, 2025
## Description There was a bug in the `ResourceFetcher` in the logic of handling release builds bundled files fetching. Not only the condition, on which we previously decided whether it is `DEV MODE` or `RELEASE MODE` was wrong but also the `moveAsync` in handling logic caused app crashes on IOS. On the android previous version was working, but approach utilizing `copyAsync` seems better suited and clearer version. ### Introduces a breaking change? - [ ] Yes - [x] No ### Type of change - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) ### Tested on - [x] iOS - [x] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
KnextKoder
pushed a commit
to Synkhiv/react-native-executorch
that referenced
this pull request
Nov 7, 2025
…#567) ## Description There was a bug in the `ResourceFetcher` in the logic of handling release builds bundled files fetching. Not only the condition, on which we previously decided whether it is `DEV MODE` or `RELEASE MODE` was wrong but also the `moveAsync` in handling logic caused app crashes on IOS. On the android previous version was working, but approach utilizing `copyAsync` seems better suited and clearer version. ### Introduces a breaking change? - [ ] Yes - [x] No ### Type of change - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) ### Tested on - [x] iOS - [x] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a bug in the
ResourceFetcherin the logic of handling release builds bundled files fetching.Not only the condition, on which we previously decided whether it is
DEV MODEorRELEASE MODEwas wrong but also themoveAsyncin handling logic caused app crashes on IOS.On the android previous version was working, but approach utilizing
copyAsyncseems better suited and clearer version.Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes