Skip to content

fix: return accumulated response from native to TS#770

Merged
chmjkb merged 4 commits into
mainfrom
@chmjkb/return-response-from-native-llm
Jan 30, 2026
Merged

fix: return accumulated response from native to TS#770
chmjkb merged 4 commits into
mainfrom
@chmjkb/return-response-from-native-llm

Conversation

@chmjkb
Copy link
Copy Markdown
Collaborator

@chmjkb chmjkb commented Jan 30, 2026

Description

Fixes #767, removes a deprecated responseCallback

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@chmjkb chmjkb added the bug fix PRs that are fixing bugs label Jan 30, 2026
@chmjkb chmjkb self-assigned this Jan 30, 2026
@chmjkb chmjkb linked an issue Jan 30, 2026 that may be closed by this pull request
@chmjkb chmjkb marked this pull request as ready for review January 30, 2026 09:55
@chmjkb chmjkb requested a review from benITo47 January 30, 2026 09:55
@chmjkb chmjkb requested a review from msluszniak January 30, 2026 10:27
@msluszniak
Copy link
Copy Markdown
Member

Could you rebase with CI fix so we see if this PR does not introduce any errors?

@chmjkb
Copy link
Copy Markdown
Collaborator Author

chmjkb commented Jan 30, 2026

Could you rebase with CI fix so we see if this PR does not introduce any errors?

the Android app compiles though, so I'm not sure if wasting CI for that is worth it :D, it's a minor change

@chmjkb chmjkb merged commit 89bcf67 into main Jan 30, 2026
4 of 5 checks passed
@chmjkb chmjkb deleted the @chmjkb/return-response-from-native-llm branch January 30, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix PRs that are fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useLLM.response async update issue

3 participants