Skip to content

fix: correct base64 data URI segment count validation in readImage#811

Open
msluszniak wants to merge 2 commits intomainfrom
pr-fix-kor
Open

fix: correct base64 data URI segment count validation in readImage#811
msluszniak wants to merge 2 commits intomainfrom
pr-fix-kor

Conversation

@msluszniak
Copy link
Member

@msluszniak msluszniak commented Feb 16, 2026

Description

A base64 data URI (e.g. data:image/png;base64,iVBOR...) splits text into 2 segments, but the check was comparing against 1, causing all valid base64 image inputs to be rejected.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Run tests and check if they work.

Screenshots

Related issues

#809

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@msluszniak msluszniak self-assigned this Feb 16, 2026
@msluszniak msluszniak added the bug fix PRs that are fixing bugs label Feb 16, 2026
@msluszniak msluszniak requested a review from benITo47 February 16, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix PRs that are fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants