feat!: make classification module a vision labeled module#986
Merged
NorbertKlockiewicz merged 3 commits intomainfrom Mar 20, 2026
Merged
feat!: make classification module a vision labeled module#986NorbertKlockiewicz merged 3 commits intomainfrom
NorbertKlockiewicz merged 3 commits intomainfrom
Conversation
131eb70 to
b5c4879
Compare
msluszniak
reviewed
Mar 20, 2026
packages/react-native-executorch/common/rnexecutorch/models/classification/Classification.cpp
Show resolved
Hide resolved
msluszniak
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ClassificationModuleinto a type-safe, labeled vision module —forward()now returnsRecord<'GOLDEN_RETRIEVER' | 'TABBY' | ..., number>instead ofRecord<string, number>Imagenet1kLabelenum (1000 ImageNet class names) as a TS constant, replacing the hardcoded C++Constants.hlabel arraynormMean/normStd) and label names configurable from JS, passed through to the nativeClassificationconstructorfromCustomModelfactory accepting aClassificationConfigwith a user-providedlabelMapand optional preprocessing paramsVisionLabeledModulebase class for shared label-mapping logicIntroduces a breaking change?
Type of change
Tested on
Testing instructions
Run classification in computer vision example app
Screenshots
Related issues
Checklist
Additional notes