Merged
Conversation
benITo47
force-pushed
the
@bo/fixSemSegTests
branch
2 times, most recently
from
12a2433 to
424622a
Compare
benITo47
force-pushed
the
@bo/fixSemSegTests
branch
from
424622a to
9efa4de
Compare
msluszniak
added
the
test
msluszniak
changed the title
msluszniak
reviewed
Mar 21, 2026
...s/react-native-executorch/common/rnexecutorch/tests/integration/SemanticSegmentationTest.cpp
Outdated
Show resolved
Hide resolved
…egration/SemanticSegmentationTest.cpp
msluszniak
approved these changes
Mar 21, 2026
Member
msluszniak
left a comment
msluszniak
left a comment
There was a problem hiding this comment.
Ran tests and everything seems to be ok. I pushed one changes to simplify one test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During a rename that recently took place - we forgot to change tests.
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Run the tests
Screenshots
Related issues
Closes #818
Checklist
Additional notes