Conversation
kmagiera
approved these changes
Jul 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is related with issue #241. Tap handler wasn't woking properly with condition
maxDeltaXandmaxDeltaYRepro
If you wish to repro this this issue, please use code from issue in Example App
Changes
onHandlemethod in TapGestureHandler was not reseting valuesmLastXandmLastYat the beginning of a gesture. It implies that the conditionshouldFail()was not working properly which was clearly illustrated withmaxDeltaX: 0andmaxDeltaY: 0in given issue. IndeedmLastXandmLastYwere representing values from previous gesture.Now reseting was added and moved before
shouldFail()condition.However, it's difficult to meet condition given in the issue(
maxDeltaX: 0andmaxDeltaY: 0) it's possibile with emulated device