Add support for hitSlop on buttons on iOS#283
Merged
kmagiera merged 1 commit intosoftware-mansion:masterfrom Sep 10, 2018
Merged
Add support for hitSlop on buttons on iOS#283kmagiera merged 1 commit intosoftware-mansion:masterfrom
kmagiera merged 1 commit intosoftware-mansion:masterfrom
Conversation
kmagiera
approved these changes
Sep 10, 2018
Member
kmagiera
left a comment
kmagiera
left a comment
There was a problem hiding this comment.
Looks great. Thanks a lot @janicduplessis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for
hitSlopfor buttons on iOS. Android already has support for it. This is pretty much a copy paste from the implementation inRCTView.Ideally we'd be able to reuse some of that code for support for things like border but I can't really think of a good solution if we want to use
UIButton.hitSlopis pretty important to add since we cannot work around it by adding an extra view (like we can for things like border).Test plan
Tested these changes in an app and made sure hit slop affected properly the touch area of a Button.