Change declaration for GestureHandlerProperties from 'string' to 'React.Ref'#298
Merged
kmagiera merged 1 commit intosoftware-mansion:masterfrom Oct 1, 2018
Conversation
m-tymchyk
force-pushed
the
gesture-handler-typescript-declarations
branch
from
3a71896 to
c4f50bc
Compare
kmagiera
requested changes
Sep 28, 2018
Member
kmagiera
left a comment
kmagiera
left a comment
There was a problem hiding this comment.
Thanks for sending this PR @m-tymchyk !
Didn't know about that Ref type. For react version compatibility reasons (versions w/o createRef) we also need to support strings and string arrays. Can you make a change to allow both waitFor and simultaneousHandlers accept string and string[] as well as the new ref types you added?
Contributor
Author
|
Type https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L61 |
Contributor
Author
|
^_^ |
janicduplessis
pushed a commit
to janicduplessis/react-native-gesture-handler
that referenced
this pull request
Feb 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.