Update `Swipeable` types by m-bert · Pull Request #4175 · software-mansion/react-native-gesture-handler

m-bert · 2026-05-13T14:27:38Z

Description

Some of the props passed to Swipeable can be SharedValue. However, we do not allow that in types, so TypeScript throws errors.

Thank you @coado with help ❤️

Test plan

Static checks

Copilot

Pull request overview

This PR updates the public TypeScript API for ReanimatedSwipeable to reflect that certain numeric configuration props may be provided as Reanimated SharedValue<number>, aligning the typings/docs with intended usage.

Changes:

Expand SwipeableProps.dragOffsetFromLeft and SwipeableProps.dragOffsetFromRight to accept SharedValue<number> in addition to number.
Update the Reanimated Swipeable docs to reflect the updated prop types.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
packages/react-native-gesture-handler/src/components/ReanimatedSwipeable/ReanimatedSwipeableProps.ts	Widens `dragOffsetFromLeft`/`dragOffsetFromRight` prop types to include `SharedValue<number>`.
packages/docs-gesture-handler/docs/components/reanimated_swipeable.mdx	Updates the documented TypeScript signatures for the same props.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

packages/react-native-gesture-handler/src/components/ReanimatedSwipeable/ReanimatedSwipeable.tsx:489

activeOffsetX requires the first tuple element to be <= 0 and the second to be >= 0 (validated by usePanGesture in DEV). Switching to [dragOffsetFromRight, dragOffsetFromLeft] changes the sign contract for dragOffsetFromRight compared to the documented/default behavior ("Defaults to 10"), and will break existing callers passing a positive number. Prefer preserving the existing API (positive distance) and handling the negation internally in a way that supports SharedValue, or update the default value + docs to explicitly require a non-positive dragOffsetFromRight.

  const panGesture = usePanGesture({
    enabled: enabled !== false,
    enableTrackpadTwoFingerGesture: enableTrackpadTwoFingerGesture,
    activeOffsetX: [dragOffsetFromRight, dragOffsetFromLeft],
    simultaneousWith,
    requireToFail,

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

j-piasecki · 2026-05-14T12:07:47Z

+    if (Reanimated?.isSharedValue<number>(dragOffsetFromRight)) {
+      // eslint-disable-next-line react-hooks/rules-of-hooks
+      Reanimated?.useDerivedValue(() => {
+        'worklet';
+        if (dragOffsetFromRight.value > 0) {
+          throw new Error(
+            tagMessage('dragOffsetFromRight should be non-positive.')
+          );
+        }
+        return dragOffsetFromRight.value;
+      });
+    } else {
+      // eslint-disable-next-line react-hooks/rules-of-hooks
+      useEffect(() => {
+        if ((dragOffsetFromRight as number) > 0) {
+          throw new Error(
+            tagMessage('dragOffsetFromRight should be non-positive.')
+          );
+        }
+      }, [dragOffsetFromRight]);
+    }
+  }


I don't think this is correct. You can switch between a constant value and a constant.

This should be a single useEffect and if the value is a shared value, add a subscriber and remove it on cleanup.

You can switch between a constant value and a constant.

You mean alternating between SharedValue and standard value? Isn't it weird use-case?

This should be a single useEffect and if the value is a shared value, add a subscriber and remove it on cleanup.

useDerivedValue was discussed with Reanimated team. But if you prefer manually adding listener than ok. wdyt?

Isn't it weird use-case?

Yes, but it's valid and would crash now.

Let me know what you think b2d4e5a

j-piasecki · 2026-05-14T12:08:30Z

+      useDerivedValue<T>(
+        updater: () => T,
+        dependencies?: readonly unknown[]
+      ): SharedValue<T>; // Not exactly, but we don't need that anyway


This will not be needed after that change.

Remove useDerivedValue

## Description Following #4175 I've decided to update types that can be passed as `SharedValue` also in `Drawer` ## Test plan Static checks

coado

looks good!

relextm19 · 2026-05-15T13:05:05Z

+      'worklet';
+      if (maybeUnpackValue<number>(value) > 0) {
+        throw new Error(
+          tagMessage('dragOffsetFromRight should be non-negative.')


Is this not a contradiction? First check if the value is more than 0 and then throw an error that says its less than 0.

Update Swipeable types

143ef23

Copilot AI review requested due to automatic review settings May 13, 2026 14:27

Copilot started reviewing on behalf of m-bert May 13, 2026 14:28 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread .../react-native-gesture-handler/src/components/ReanimatedSwipeable/ReanimatedSwipeableProps.ts Outdated

m-bert mentioned this pull request May 13, 2026

Closing an open Swipeable row conflicts with iOS native back gesture #4104

Closed

Change logic

e842967

m-bert requested a review from Copilot May 13, 2026 16:07

Copilot started reviewing on behalf of m-bert May 13, 2026 16:08 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

m-bert added 6 commits May 13, 2026 18:14

Change default value to negative

23de6d7

Update docs

b613295

Update migration guide

67cf888

missing T

33240ab

Update other types

0401093

Merge branch 'main' into @mbert/update-types

a33c735

m-bert requested a review from Copilot May 14, 2026 08:27

Copilot started reviewing on behalf of m-bert May 14, 2026 08:28 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread packages/docs-gesture-handler/docs/guides/upgrading-to-3.mdx Outdated

Comment thread ...ages/react-native-gesture-handler/src/components/ReanimatedSwipeable/ReanimatedSwipeable.tsx Outdated

Comment thread skills/gesture-handler-3-migration/SKILL.md

m-bert and others added 3 commits May 14, 2026 10:34

Typo

80e8a75

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Update docs

46c9bc7

React also to SharedValue changes

7818a44

m-bert requested a review from Copilot May 14, 2026 09:48

Copilot started reviewing on behalf of m-bert May 14, 2026 09:49 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Add missing ?

9e75c0e

m-bert requested a review from Copilot May 14, 2026 09:59

Copilot started reviewing on behalf of m-bert May 14, 2026 09:59 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

m-bert marked this pull request as ready for review May 14, 2026 10:01

m-bert requested a review from j-piasecki May 14, 2026 10:02

m-bert requested review from coado and relextm19 May 14, 2026 10:02

j-piasecki reviewed May 14, 2026

View reviewed changes

m-bert mentioned this pull request May 14, 2026

Update ReanimatedDrawerLayout types #4178

Merged

m-bert added a commit that referenced this pull request May 15, 2026

Update ReanimatedDrawerLayout types (#4178)

ce30139

## Description Following #4175 I've decided to update types that can be passed as `SharedValue` also in `Drawer` ## Test plan Static checks

m-bert added 3 commits May 15, 2026 11:26

Change check

2d06c35

Fix check again

b2d4e5a

Remove useDerivedValue

d01be7f

m-bert requested a review from j-piasecki May 15, 2026 09:46

coado approved these changes May 15, 2026

View reviewed changes

relextm19 reviewed May 15, 2026

View reviewed changes

Uh oh!

Conversation

m-bert commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

j-piasecki May 14, 2026

Choose a reason for hiding this comment

Uh oh!

m-bert May 14, 2026

Choose a reason for hiding this comment

Uh oh!

j-piasecki May 15, 2026

Choose a reason for hiding this comment

Uh oh!

m-bert May 15, 2026

Choose a reason for hiding this comment

Uh oh!

j-piasecki May 14, 2026

Choose a reason for hiding this comment

Uh oh!

m-bert May 15, 2026

Choose a reason for hiding this comment

Uh oh!

coado left a comment

Choose a reason for hiding this comment

Uh oh!

relextm19 May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

m-bert commented May 13, 2026 •

edited

Loading