[iOS] Fix duplicated testID#4186
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an iOS/Fabric issue where testID was applied to both the wrapper component view and the underlying button, causing e2e frameworks (e.g. Detox) to see multiple matches for a single by.id(...) query.
Changes:
- Clears
accessibilityIdentifierfrom the wrapper view after Fabric’ssuper updatePropsappliestestID, so only the actual_buttonViewkeeps the identifier.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coado
approved these changes
May 21, 2026
j-piasecki
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes duplicated
testIDprop on iOS. SameaccessibilityLabelwas assigned to both, wrapper and button, therefore frameworks likeDetoxfailed due to multiple elements with the same ID.Fixes #3698
Test plan
Tested on branch with e2e tests.