[iOS] Don't iterate to root while resolving recognizer#4202
Merged
Conversation
m-bert
approved these changes
May 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts iOS gesture-handler lookup logic to avoid traversing all the way to the root view when trying to resolve a UIGestureRecognizer to an RNGestureHandler, restoring the “stop at React Native–managed views” semantics that existed in the old architecture.
Changes:
- Update
findGestureHandlerByRecognizer:to walk superviews looking for anRNDummyGestureRecognizer, but stop once a React Native Fabric-managed view (RCTViewComponentView) is reached. - Avoid local-variable shadowing by renaming the inner loop variable from
recognizertocandidateRecognizer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The updated loop in #4199 didn't accurately represent the semantics from the old arch. It didn't stop on the views managed by React Native, instead iterating to the root of the hierarchy.
Test plan
Checked that it doesn't regress #4199