Skip to content

fix(CI): change order of events in Fabric iOS events e2e test #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kligarski merged 3 commits into from
Mar 18, 2025
Merged

fix(CI): change order of events in Fabric iOS events e2e test #2785

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
665b8ee
change order of events in the e2e test
kligarski Mar 18, 2025
a62f697
add explanation for the change
kligarski Mar 18, 2025
800795c
shorten in-code comment, add PR link
kligarski Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions FabricExample/e2e/examplesTests/events.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ const pressBack = async () => {

const awaitClassicalEventBehavior = async () => {
if (device.getPlatform() === 'ios') {
// The order of events in this test differs from the Paper version of the same test.
// Please see https://github.com/software-mansion/react-native-screens/pull/2785 for details.
await expect(
element(by.text('9. Chats | transitionStart | closing')),
).toExist();
Expand All @@ -21,14 +23,14 @@ const awaitClassicalEventBehavior = async () => {
await expect(
element(by.text('11. Main | transitionStart | opening')),
).toExist();
await expect(element(by.text('12. Privacy | beforeRemove'))).toExist();
await expect(element(by.text('13. Chats | beforeRemove'))).toExist();
await expect(
element(by.text('12. Chats | transitionEnd | closing')),
element(by.text('14. Chats | transitionEnd | closing')),
).toExist();
await expect(
element(by.text('13. Privacy | transitionEnd | closing')),
element(by.text('15. Privacy | transitionEnd | closing')),
).toExist();
await expect(element(by.text('14. Privacy | beforeRemove'))).toExist();
await expect(element(by.text('15. Chats | beforeRemove'))).toExist();
await expect(
element(by.text('16. Main | transitionEnd | opening')),
).toExist();
Expand Down
Loading