Skip to content

Conversation

@tomek0123456789
Copy link
Contributor

Closes #

Introduced changes

  • This PR contains breaking changes

@tomek0123456789 tomek0123456789 requested a review from drknzz August 25, 2023 09:39
@tomek0123456789 tomek0123456789 self-assigned this Aug 25, 2023
Copy link
Contributor

@drknzz drknzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍😎👍

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 85.93% and project coverage change: -10.39% ⚠️

Comparison is base (0243f05) 96.99% compared to head (5b4c181) 86.60%.
Report is 6 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff                @@
##           development    #1167       +/-   ##
================================================
- Coverage        96.99%   86.60%   -10.39%     
================================================
  Files               92       92               
  Lines             4419     4493       +74     
================================================
- Hits              4286     3891      -395     
- Misses             133      602      +469     
Files Changed Coverage Δ
starknet_py/net/signer/test_stark_curve_signer.py 0.00% <0.00%> (-100.00%) ⬇️
starknet_py/net/signer/stark_curve_signer.py 97.01% <81.81%> (-2.99%) ⬇️
starknet_py/net/client_models.py 99.70% <100.00%> (-0.30%) ⬇️
starknet_py/net/gateway_client.py 93.16% <100.00%> (-3.44%) ⬇️
starknet_py/net/schemas/gateway.py 98.19% <100.00%> (-0.53%) ⬇️

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomek0123456789 tomek0123456789 merged commit 4edbde3 into development Aug 25, 2023
@tomek0123456789 tomek0123456789 deleted the fix/non-prefixed-hex branch August 25, 2023 10:16
tomek0123456789 added a commit that referenced this pull request Sep 6, 2023
tomek0123456789 added a commit that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants