Skip to content

Conversation

@tomek0123456789
Copy link
Contributor

@tomek0123456789 tomek0123456789 commented Sep 6, 2023

Closes #1166

Introduced changes

  • revert a hack for 0.12.1 regarding get_block and get_state_update

  • This PR contains breaking changes

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 90.78% and project coverage change: +0.09% 🎉

Comparison is base (0243f05) 96.99% compared to head (82469a3) 97.08%.
Report is 8 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1176      +/-   ##
===============================================
+ Coverage        96.99%   97.08%   +0.09%     
===============================================
  Files               92       92              
  Lines             4419     4489      +70     
===============================================
+ Hits              4286     4358      +72     
+ Misses             133      131       -2     
Files Changed Coverage Δ
starknet_py/net/account/account.py 95.08% <46.15%> (-3.76%) ⬇️
starknet_py/net/client_models.py 100.00% <100.00%> (ø)
starknet_py/net/gateway_client.py 96.81% <100.00%> (+0.21%) ⬆️
starknet_py/net/schemas/gateway.py 99.09% <100.00%> (+0.37%) ⬆️
starknet_py/net/signer/stark_curve_signer.py 100.00% <100.00%> (ø)
starknet_py/net/signer/test_stark_curve_signer.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomek0123456789 tomek0123456789 changed the title revert #1167 revert #1167, #1154 Sep 6, 2023
@tomek0123456789 tomek0123456789 force-pushed the tomek/1166-remove-felt-hack branch from 9db56c4 to 82469a3 Compare September 6, 2023 14:36
@tomek0123456789 tomek0123456789 changed the title revert #1167, #1154 revert #1167 Sep 6, 2023
@tomek0123456789 tomek0123456789 merged commit c8c8af2 into development Sep 8, 2023
@tomek0123456789 tomek0123456789 deleted the tomek/1166-remove-felt-hack branch September 8, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change NonPrefixedHex to Felt in schemas after mainnet 0.12.2

3 participants