Move test_impersonate_account test to tests_on_networks
#1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1481 +/- ##
===============================================
- Coverage 96.97% 92.85% -4.13%
===============================================
Files 93 107 +14
Lines 4766 5497 +731
===============================================
+ Hits 4622 5104 +482
- Misses 144 393 +249
|
This reverts commit 20c7313.
franciszekjob
commented
Sep 9, 2024
Collaborator
Author
franciszekjob
left a comment
franciszekjob
left a comment
There was a problem hiding this comment.
Changes in client_test.py, fixtures.py and trace_api_test.py were added to fix linting.
franciszekjob
changed the title
test_impersonate_account test to tests_on_networks
franciszekjob
changed the title
test_impersonate_account test to tests_on_networkstest_impersonate_account test to tests_on_networks
kkawula
suggested changes
Sep 9, 2024
Contributor
kkawula
left a comment
kkawula
left a comment
There was a problem hiding this comment.
I suppose that all tests from starknet_py/tests/e2e/client_devnet/account_impersonate_test.py should be moved to
starknet_py/tests/e2e/tests_on_networks/client_devnet/account_impersonate_test.py.
Also all fixtures related with fork or f_ prefix from starknet_py/tests/e2e/client_devnet/fixtures should be moved, because I suppose that in can generate error during setup.
franciszekjob
deleted the
franciszekjob/1480-move-devnet-client-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1480
Introduced changes
test_impersonate_accounttest totests_on_networks