Skip to content

[WIP] S-DAC Carbon Revenue Fix [BICYCLE econ model] [v3.14]#153

Open
softwareengineerprogrammer wants to merge 4 commits into
mainfrom
s-dac-carbon-revenue_bicycle-econ-model
Open

[WIP] S-DAC Carbon Revenue Fix [BICYCLE econ model] [v3.14]#153
softwareengineerprogrammer wants to merge 4 commits into
mainfrom
s-dac-carbon-revenue_bicycle-econ-model

Conversation

@softwareengineerprogrammer
Copy link
Copy Markdown
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented May 20, 2026

Description

Addresses NatLabRockies#341

TODO

  1. Documentation
    1. README example list entry
  2. Disable support for SAM-EM (if not already) and document as limitation

Testing & Verification

  1. Unit tests added: N/A
  2. Unit tests updated:
    1. S-DAC-GT
    2. test_parse_sdacgt_profile
  3. Manual testing:
    1. 🚧 Web interface:
      1. https://gtp.scientificwebservices.com/geophires/?geophires-example-id=S-DAC-GT

Change Checklist:

Observe the following checklist items if your change includes a new version (see versioning notes and version management docs).

Before merging:

  1. Add a CHANGELOG entry (example). RST Template:
4.14: `TITLE <https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER>`__ | `release <https://github.com/NREL/GEOPHIRES-X/releases/tag/v3.14.P>`__

After merging:

  1. Push tag(s) to GitHub: git push origin refs/tags/v3.14.P
  2. Post a change announcement to the GEOPHIRES Change Announcements Discussion (example). Markdown template:
3.14: [TITLE](https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER) | [release](https://github.com/NREL/GEOPHIRES-X/releases/tag/vM.m.P)

Self-reviewed in #154

@softwareengineerprogrammer softwareengineerprogrammer changed the title S-DAC Carbon Revenue FIx [BICYCLE econ model] [v3.14] [WIP] S-DAC Carbon Revenue FIx [BICYCLE econ model] [v3.14] May 20, 2026
@softwareengineerprogrammer softwareengineerprogrammer changed the title [WIP] S-DAC Carbon Revenue FIx [BICYCLE econ model] [v3.14] [WIP] S-DAC Carbon Revenue Fix [BICYCLE econ model] [v3.14] May 20, 2026
@softwareengineerprogrammer softwareengineerprogrammer added the wontfix This will not be worked on label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant