Conversation
Member
|
One thing that we're missing are the docs :) |
adamw
reviewed
Jan 7, 2026
| * @param <K> The type of the key. | ||
| * @param <V> The type of the value. | ||
| */ | ||
| public record ReceivedMessage<K, V>(ConsumerRecord<K, V> consumerRecord) { |
Member
There was a problem hiding this comment.
do we need this? seems like a pass-through
Contributor
Author
There was a problem hiding this comment.
Do you mean not to wrap ConsumerRecord in ReceivedMessage and expose it directly?
Member
There was a problem hiding this comment.
Yes. I don't think there's much benefit in the wrapper?
Contributor
Author
There was a problem hiding this comment.
It's some kind of compatibility layer, but at the moment I don't see many benefits either. I will remove that.
Contributor
Author
|
I've added docs for Kafka module |
Member
|
Thanks, now to releasing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Kafka module ported from Ox to Java, providing Kafka producer and consumer support based on the original Ox design.