Skip to content

fix: benchmark infrastructure — JVM heap, Liquibase, MockProducer leak #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
endrju19 merged 2 commits into from
May 17, 2026
Merged

fix: benchmark infrastructure — JVM heap, Liquibase, MockProducer leak #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f00743a
fix: benchmark infrastructure — JVM heap, Liquibase, MockProducer leak
endrju19 May 17, 2026
941513c
style: fix import order in DelivererMicroBenchmark per ktlint
endrju19 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion okapi-benchmarks/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,19 @@ jmh {
timeOnIteration = "30s"
resultFormat = "JSON"
resultsFile = layout.buildDirectory.file("reports/jmh/results.json")
jvmArgs = listOf("-Xms2g", "-Xmx2g", "-XX:+UseG1GC")
jvmArgs = listOf(
// Throughput-mode microbenchmarks call deliver() in a tight loop and re-deserialize
// KafkaDeliveryInfo via Jackson + Kotlin reflection per invocation; with -Xmx2g this
// OOMs within the first measurement iteration. 8g leaves room for GC under sustained
// allocation pressure without skewing the benchmark with promotion stalls.
"-Xms8g",
"-Xmx8g",
"-XX:+UseG1GC",
// okapi-postgres.jar and the fat JMH jar both end up on the classpath; both carry
// the Liquibase changelog. Liquibase 4.x treats this as an error by default. The
// files are identical (same jar source on the classpath twice), so WARN is safe.
"-Dliquibase.duplicateFileMode=WARN",
)
}

// ktlint should not lint JMH-generated sources.
Expand Down
16 changes: 15 additions & 1 deletion okapi-benchmarks/src/jmh/kotlin/com/softwaremill/okapi/benchmarks/DelivererMicroBenchmark.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import com.softwaremill.okapi.http.ServiceUrlResolver
import com.softwaremill.okapi.kafka.KafkaDeliveryInfo
import com.softwaremill.okapi.kafka.KafkaMessageDeliverer
import org.apache.kafka.clients.producer.MockProducer
import org.apache.kafka.clients.producer.ProducerRecord
import org.apache.kafka.clients.producer.RecordMetadata
import org.apache.kafka.common.serialization.StringSerializer
import org.openjdk.jmh.annotations.Benchmark
import org.openjdk.jmh.annotations.BenchmarkMode
Expand All @@ -25,6 +27,7 @@ import org.openjdk.jmh.annotations.Setup
import org.openjdk.jmh.annotations.State
import org.openjdk.jmh.annotations.TearDown
import java.time.Instant
import java.util.concurrent.Future
import java.util.concurrent.TimeUnit

/**
Expand Down Expand Up @@ -52,7 +55,18 @@ open class DelivererMicroBenchmark {

@Setup(org.openjdk.jmh.annotations.Level.Trial)
fun setupTrial() {
val mockProducer = MockProducer(true, null, StringSerializer(), StringSerializer())
// MockProducer.send() appends every record to an internal `sent` list (exposed as
// history()) and never drops it. In throughput-mode at ~1M ops/s for 30s × multiple
// iterations × forks that list grows to GBs and OOMs the JVM regardless of -Xmx.
// Override send() to discard history after each call — for microbench we don't need
// to inspect what was sent, only to measure deliver() overhead.
val mockProducer = object : MockProducer<String, String>(true, null, StringSerializer(), StringSerializer()) {
override fun send(record: ProducerRecord<String, String>): Future<RecordMetadata> {
val future = super.send(record)
clear()
return future
}
}
kafkaDeliverer = KafkaMessageDeliverer(mockProducer)

wiremock = WireMockServer(wireMockConfig().dynamicPort()).also { it.start() }
Expand Down