Make Flow.range support descending ranges with negative step#455
Merged
Conversation
Member
Author
|
The failure is clear. Here's the summary: CI failure: Both
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #439 — Flow.range with a negative step was only emitting the first element due to incorrect termination logic.
The original implementation used a fixed termination condition (
t <= to) that didn't account for negative steps. With a negative step, this condition would cause the loop to terminate prematurely.The fix updates the range method to:
t <= tofor positive steps,t >= tofor negative stepsTest cases for descending ranges have been added to verify the fix works correctly.
Closes #439.