Skip to content
This repository was archived by the owner on Apr 27, 2023. It is now read-only.

Conversation

@mkubala
Copy link
Member

@mkubala mkubala commented Oct 18, 2016

Current limitation came from the scala.Tuple-based implementation of the toString generated by Stringmask macro.

This PR introduces a new reduceLeftOption-based way of combining Trees, which allows us to get rid of scala.Tuples

Current limitation came from the scala.Tuple-based implementation of the `toString` generated by Stringmask macro.
This commit introduces a new reduceLeftOption-based solution which allows us to get rid of `scala.Tuple`s from the generated code.
@kciesielski kciesielski added this to the 1.2.0 milestone Oct 19, 2016
@kciesielski
Copy link
Member

Great job, thanks @mkubala :)

@kciesielski kciesielski merged commit bac47cf into softwaremill:master Nov 10, 2016
@mkubala mkubala deleted the feature/support-more-than-22-fields branch November 10, 2016 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants