Conversation
mijicd
commented
Feb 15, 2026
mijicd
commented
Feb 15, 2026
| if: matrix.java == '21' | ||
| run: echo "WITH_ZIO=1" >> $GITHUB_ENV | ||
| - name: Enable Loom-specific modules | ||
| if: matrix.target-platform == 'JVM' && matrix.java == '21' && matrix.scala-version == '3' |
Contributor
Author
There was a problem hiding this comment.
Note that this excludes zio project, but it resembles the old behavior where no modules but loom ones are tested/published for this particular build point (3, JVM, 21). We can adjust this if necessary (e.g. using ALSO_LOOM?).
mijicd
commented
Feb 15, 2026
|
|
||
| lazy val loomProjects: Seq[String] = Seq(ox, examples).flatMap(_.projectRefs).flatMap(projectId) | ||
| lazy val loomProjects: Seq[String] = Seq(ox, examples, zioJson).flatMap(_.projectRefs).flatMap(projectId) | ||
| lazy val zioProjects: Seq[String] = Seq(zioJson).flatMap(_.projectRefs).flatMap(projectId) |
Contributor
Author
There was a problem hiding this comment.
Note that zio1Json is still around, but it is heavily deprecated, therefore, I did not include it here. I would propose removing it at one point.
Member
|
Thanks, let's see if the release works properly :) |
Contributor
Author
|
@adamw Unfortunately, it didn't work. I notice an unwanted leftover (see this comment), but I can't explain the lack of zio-json artifact 😞 . Looking into it. |
adamw
pushed a commit
that referenced
this pull request
Feb 16, 2026
Resolves issues introduced by #2804: - It enabled the native build for zio-json, which wasn't there before (while possible, it needs a bit work) - Restored "Enable Native-specific modules" release condition (i.e. `target-platform` does not exist there 🤦♂️, see 923fbe7) - Adjusted "Enable Loom-specific modules" release condition (the same as previous, see 39ef8bc) Before submitting pull request: - [x] Check if the project compiles by running `sbt compile` - [x] Verify docs compilation by running `sbt compileDocs` - [x] Check if tests pass by running `sbt test` - [x] Format code by running `sbt scalafmt`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2792, closes #2715
Before submitting pull request:
sbt compilesbt compileDocssbt testsbt scalafmt