Render multipart filename, content-type, and per-part headers in toCurl#2893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2881. The toCurl converter was dropping multipart metadata (filename, content-type, and custom headers) when generating curl command output. This made the generated curl commands incomplete and unable to faithfully reproduce the original HTTP request.
This change adds support for emitting multipart metadata using curl's form-field extensions:
;filename=parameter;type=parameter;headers=parameter (Content-Type is filtered to avoid duplication)Values containing single quotes are escaped with backslashes to ensure proper shell syntax. Tests cover all metadata combinations including edge cases with special characters.
Closes #2881.