Merged
Conversation
adamw
reviewed
Jun 10, 2021
|
|
||
| trait SchemaDerivation extends SchemaMagnoliaDerivation { | ||
| inline implicit def schemaForCaseClass[T](using Mirror.Of[T]): Derived[Schema[T]] = Derived(derived[T]) | ||
| inline implicit def schemaForCaseClass[T](implicit m: Mirror.Of[T], cfg: Configuration): Derived[Schema[T]] = Derived(derived[T]) |
Member
There was a problem hiding this comment.
using doesn't work or it's just more convenient to use implicit? Maybe we could also try defining this using the given syntax?
Contributor
Author
There was a problem hiding this comment.
I just didn't want to mix up given/using with implicits.
Unfortunately we cannot go with the given syntax, because of compatibility with scala 2.x (it would require import sttp.tapir.generic.auto.given instead of import sttp.tapir.generic.auto._)
adamw
approved these changes
Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.