Skip to content

fix(http4s-client): exclude empty query params from URI#1308

Merged
adamw merged 1 commit intosoftwaremill:masterfrom
MichalPawlicki:fix-http4s-client/exclude-empty-optional-query-params
Jun 11, 2021
Merged

fix(http4s-client): exclude empty query params from URI#1308
adamw merged 1 commit intosoftwaremill:masterfrom
MichalPawlicki:fix-http4s-client/exclude-empty-optional-query-params

Conversation

@MichalPawlicki
Copy link
Copy Markdown
Contributor

Fixes #1306

Comment thread build.sbt
http4sClient.projectRefs ++
sttpClient.projectRefs ++
playClient.projectRefs ++
http4sClient.projectRefs ++
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already added in line 122.

@adamw adamw merged commit 417064a into softwaremill:master Jun 11, 2021
@adamw
Copy link
Copy Markdown
Member

adamw commented Jun 11, 2021

Thanks! :)

@MichalPawlicki MichalPawlicki deleted the fix-http4s-client/exclude-empty-optional-query-params branch June 11, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] http4s client renders optional query params even when values are None

2 participants