#1317 fix http4s swagger contextPath for multi path part#1318
Merged
adamw merged 1 commit intosoftwaremill:masterfrom Jun 18, 2021
Merged
Conversation
stsatlantis
commented
Jun 13, 2021
Contributor
Author
stsatlantis
left a comment
stsatlantis
left a comment
There was a problem hiding this comment.
Left to comment for the reviewers for consideration of the two possible fix proposals.
| class SwaggerHttp4s( | ||
| yaml: String, | ||
| contextPath: String = "docs", | ||
| contextPath: List[String] = List("docs"), |
Contributor
Author
There was a problem hiding this comment.
Kept for compatibility with the previous version when the context path is not defined.
| class SwaggerHttp4s( | ||
| yaml: String, | ||
| contextPath: String = "docs", | ||
| contextPath: List[String] = List("docs"), |
Contributor
Author
There was a problem hiding this comment.
To have binary compatibility the function can take a String and the rootPath would be Path(contextPath) instead of the current implementation.
Member
There was a problem hiding this comment.
This will be part of 0.18 so binary compat is not a must
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.