fixed referencing enums for optional fields#1327
Merged
adamw merged 2 commits intosoftwaremill:masterfrom Jun 18, 2021
Merged
Conversation
01c3263 to
2969eab
Compare
Member
|
Thank you! |
Contributor
Author
|
Thank you for such quick response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found that during documentation generation if a class contains an optional enum field then
referenceEnumsisn't affecting the result.For example, if I have the enum:
and use it in the class:
Then generated documentation would use a reference to specify the type of
enumFieldand will inline all options forenumFieldOpt.I've found that the problem was inside
TSchemaToASchema.scalabecause was not handled in a case when an option field might contain an enum.