fixed docs generation of referenced enums when they're inside of a collection#1341
Merged
adamw merged 4 commits intosoftwaremill:masterfrom Jun 29, 2021
Merged
Conversation
Contributor
Author
|
By some reason the CI check is failed during the repo checkout step. |
…i-docs-fix # Conflicts: # docs/apispec-docs/src/main/scala/sttp/tapir/docs/apispec/schema/ToObjectSchema.scala
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found a bug that occurs during generation of a documentation for a type with an enum which is inside of a collection (for example inside
Option) and only if I want to make a type reference for this enum. Enums which were inlined into documentation was generated without a problem.I've extended one of the test cases to demonstrate this bug.
The problem was during collection of
ObjectSchemas for endpoint inToObjectSchema. ObjectSchema for that specific enum was skipped during schema collection process and documentation generation failed with an error like thisjava.util.NoSuchElementException: key not found: SObjectInfo(CornerStyle,List())