Change backend client for awsLambda#1365
Merged
Conversation
ghost
requested a review
from 
ghost
assigned
adamw
reviewed
Jul 8, 2021
| libraryDependencies ++= loggerDependencies, | ||
| libraryDependencies ++= Seq( | ||
| "com.softwaremill.sttp.client3" %% "http4s-ce2-backend" % Versions.sttp, | ||
| "org.http4s" %% "http4s-blaze-client" % Versions.http4sOld |
Member
There was a problem hiding this comment.
maybe it's possible to remove the constant Versions.http4sOld now?
adamw
reviewed
Jul 8, 2021
|
|
||
| abstract class AwsLambdaRuntime[F[_]: ContextShift: ConcurrentEffect] extends StrictLogging { | ||
| def endpoints: Iterable[ServerEndpoint[_, _, _, Any, F]] | ||
| abstract class AwsLambdaRuntime extends StrictLogging { |
Member
There was a problem hiding this comment.
we have to keep the F constraint here, as the endpoints we want to use should be parametrised with F as well. See this backend: https://sttp.softwaremill.com/en/latest/backends/fs2.html#using-httpclient-java-11
Member
|
Unfortunately |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1326