codegen: various minor fixes and improvements#5374
Merged
adamw merged 10 commits intoJul 7, 2026
Merged
Conversation
Contributor
Author
|
I don't want to deal with merge conflicts on the other prs 😅 so I'm leaving as a draft for now EDIT: OK rebased now |
80a3f24 to
f529f57
Compare
hughsimpson
commented
Jul 7, 2026
| EnumExtraParamSupport(enumName, T) | ||
| sealed trait ADTWithDiscriminator | ||
| sealed trait ADTWithDiscriminator { def `type`: String } | ||
| sealed trait ADTWithDiscriminatorNoMapping |
Contributor
Author
There was a problem hiding this comment.
The def isn't generated here because the property name is noMapType on this oneOf and the children don't declare that field. I think that's strictly speaking invalid openapi but anyway...
b0eca6a to
6d1ccb3
Compare
7301b76 to
70cdeb8
Compare
Member
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few sundry things:
def $discriminatorName: String = "...", but the parent type didn't declare the abstract method, which was irritating. Parent will now declare the method.seperateFilesForModels=trueopenapiAlwaysGenerateParamSupportboolean flag, so that enums can be defined in an inherited openapi and used in path position, without having to redeclare them (and everything that transitively contains them).mapinstead of a.flatMapand producing e.g.?myParam=List(uuid1),List(uuid2)instead of?myParam=uuid1,uuid2when encoding)