Fix #4354: [BUG] mapTo fails to compile if case class is defined inside object#5377
Merged
Merged
Conversation
…pply overloads on Scala 2
dabrowski-adam
changed the title
mapInTo
dabrowski-adam
commented
Jul 6, 2026
| val tupleType = weakTypeOf[TUPLE] | ||
| val tupleTypeArgs = tupleType.dealias.typeArgs | ||
| if (caseClassUtil.fields.size == 0) { | ||
| q"(t: ${tupleType.dealias}) => ${caseClassUtil.className}()" |
Contributor
Author
There was a problem hiding this comment.
I went all in on supporting the companion object apply method, but I noticed that the Scala 3 code path doesn't use it and instead calls the constructor directly.
Should we align the Scala 2 implementation to use new?
Member
There was a problem hiding this comment.
Let's keep the changes minimal to this bug. It is a discrepancy but not sure if it's worth fixing
adamw
reviewed
Jul 7, 2026
| lazy val companion: Tree = { | ||
| val name = TermName(t.typeSymbol.name.decodedName.toString) | ||
| t.dealias match { | ||
| case TypeRef(pre, _, _) if pre != NoPrefix => Select(c.internal.gen.mkAttributedQualifier(pre), name) |
Member
There was a problem hiding this comment.
will this work if there's a case class nested inside an object, and nested inside another object? That is, two levels deep? Maybe we should add such test
adamw
requested changes
Jul 7, 2026
Member
|
Great to have this fixed, thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4354