codegen: Refactor structure more#5386
Merged
adamw merged 4 commits intoJul 7, 2026
Merged
Conversation
Contributor
Author
|
I'll re-open this later EDIT: It's later now |
Contributor
Author
|
@adamw last one I had queued up I swear |
Member
|
No no, keep them coming :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to make the codebase less intimidating, this splits up the files a little more. Most notably, the ~1.3k line
EndpointGenerator.scalais partitioned into multiple files in its own package. There's probably a bunch of 'more useful' refactors to be done, like replacing more tuples & common param sets with case classes, but this is still an improvement. We'll get there...No functionality changes, although the pr to do something where status codes are ambiguous on models had these changes first. It made it a lot easier to find the right bits to touch... (That's still WIP though because the approach isn't very nice to use)