MPT-21137 Fetch organization users from ffc-api#22
Merged
ffaraone merged 1 commit intoMay 28, 2026
Merged
Conversation
ffaraone
reviewed
May 27, 2026
| last_login: datetime.datetime | None = None | ||
|
|
||
|
|
||
| class OrganizationEmployeeRead(EmployeeRead): |
Contributor
There was a problem hiding this comment.
why we want to introduce this new schema ?
Contributor
Author
There was a problem hiding this comment.
EmployeeRead is used for get/create employee and as roles are never None, those get/create responses had roles as empty list. It looked confusing to me, so I added new schema
ffaraone
approved these changes
May 27, 2026
bdjilka
force-pushed
the
MPT-21137-adopt-backend-for-admin-portal-organization-user-tab
branch
from
44031ab to
c36885e
Compare
ffaraone
reviewed
May 27, 2026
bdjilka
force-pushed
the
MPT-21137-adopt-backend-for-admin-portal-organization-user-tab
branch
from
c36885e to
c55ca69
Compare
ffaraone
approved these changes
May 28, 2026
ffaraone
force-pushed
the
MPT-21137-adopt-backend-for-admin-portal-organization-user-tab
branch
from
c55ca69 to
f4fe5e4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.