Skip to content

MPT-19124 mark chat tests as skipped pending MPT-19124 completion#240

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-19124
Mar 20, 2026
Merged

MPT-19124 mark chat tests as skipped pending MPT-19124 completion#240
jentyk merged 1 commit intomainfrom
feat/MPT-19124

Conversation

@jentyk
Copy link
Member

@jentyk jentyk commented Mar 20, 2026

Closes MPT-19124

  • Marked chat-related E2E tests as skipped pending completion of MPT-19124 across multiple test modules:
    • Chat attachment tests (both async and sync variants)
    • Chat links tests (both async and sync variants)
    • Chat messages tests (both async and sync variants)
    • Chat operations tests (both async and sync variants)
  • Added @pytest.mark.skip(reason="Unskip after MPT-19124 completed") decorator to test functions
  • Test logic and assertions remain unchanged; only execution behavior modified to skip these tests
  • Affected test functions include: test_list_chat_*, test_create_chat_*, test_get_chat*, test_update_chat_*, test_delete_chat_*, and related error-case tests (test_*_not_found)

@jentyk jentyk requested a review from a team as a code owner March 20, 2026 13:11
@jentyk jentyk requested review from robcsegal and svazquezco March 20, 2026 13:11
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4b6c58ec-4112-417c-ac5d-7b49070fb7f5

📥 Commits

Reviewing files that changed from the base of the PR and between d5b28dc and 4cda4f8.

📒 Files selected for processing (8)
  • tests/e2e/helpdesk/chats/attachment/test_async_attachment.py
  • tests/e2e/helpdesk/chats/attachment/test_sync_attachment.py
  • tests/e2e/helpdesk/chats/links/test_async_links.py
  • tests/e2e/helpdesk/chats/links/test_sync_links.py
  • tests/e2e/helpdesk/chats/messages/test_async_messages.py
  • tests/e2e/helpdesk/chats/messages/test_sync_messages.py
  • tests/e2e/helpdesk/chats/test_async_chats.py
  • tests/e2e/helpdesk/chats/test_sync_chats.py

📝 Walkthrough

Walkthrough

Added pytest skip decorators to multiple E2E helpdesk chat-related tests across synchronous and asynchronous test files (attachments, links, messages, and base chat tests), marking them to be skipped pending completion of MPT-19124.

Changes

Cohort / File(s) Summary
Attachment E2E Tests
tests/e2e/helpdesk/chats/attachment/test_async_attachment.py, tests/e2e/helpdesk/chats/attachment/test_sync_attachment.py
Added @pytest.mark.skip(reason="Unskip after MPT-19124 completed") decorator to all attachment-related test functions including list, create, get, update, download, and delete operations, plus not-found error cases.
Chat Links E2E Tests
tests/e2e/helpdesk/chats/links/test_async_links.py, tests/e2e/helpdesk/chats/links/test_sync_links.py
Added skip decorators to chat link test functions covering list, create, update name, delete, and not-found scenarios.
Chat Messages E2E Tests
tests/e2e/helpdesk/chats/messages/test_async_messages.py, tests/e2e/helpdesk/chats/messages/test_sync_messages.py
Added skip decorators to message test functions including list, create, update visibility, delete, and not-found error cases.
Chat Base E2E Tests
tests/e2e/helpdesk/chats/test_async_chats.py, tests/e2e/helpdesk/chats/test_sync_chats.py
Added skip decorators to get, list, and update chat test functions; not-found tests remain undecorated.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • PR #236: Directly related as this PR skips the attachment-related test functions introduced in that PR.
  • PR #227: Directly related as this PR adds skip decorators to the same E2E helpdesk chat test functions introduced in that PR.
  • PR #237: Directly related as this PR skips the chat-links E2E test functions introduced in that PR.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Single Commit Required ⚠️ Warning PR contains multiple commits modifying the same test files instead of one atomic commit. Squash all commits into a single commit using git rebase or git reset to maintain a clean git history for this PR.
✅ Passed checks (2 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains the Jira issue key MPT-19124 in the required format MPT-XXXX.
Test Coverage Required ✅ Passed PR only modifies test files in tests/ directory; no source code files were changed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@jentyk jentyk merged commit c59571f into main Mar 20, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19124 branch March 20, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants