MPT-19482 unskip forms e2e tests and add fixtures for published forms

[jentyk]

Closes MPT-19482

Release Notes

• Added created_published_form and async_created_published_form pytest fixtures to publish Helpdesk forms before running tests
• Unskipped 5 async e2e form tests (test_get_form, test_list_forms, test_update_form, test_publish_form, test_delete_form) to enable active execution
• Unskipped 6 sync e2e form tests (test_get_form, test_list_forms, test_create_form, test_update_form, test_publish_form, test_delete_form) to enable active execution
• Updated test_unpublish_form in both sync and async test files to use the new published form fixtures and validate unpublish operation with explicit status assertion

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 301055d4-b2dc-4c7b-a0ba-094f73f4846c

📥 Commits

Reviewing files that changed from the base of the PR and between 4635cda and 8fd2cbd.

📒 Files selected for processing (3)

• tests/e2e/helpdesk/forms/conftest.py
• tests/e2e/helpdesk/forms/test_async_forms.py
• tests/e2e/helpdesk/forms/test_sync_forms.py

---

📝 Walkthrough

Walkthrough

This PR enables previously skipped e2e tests for the Helpdesk forms API and introduces new fixtures that publish forms. Two new pytest fixtures (created_published_form and async_created_published_form) are added to support testing unpublish operations on already-published forms.

Changes

Cohort / File(s)	Summary
New Published Form Fixtures tests/e2e/helpdesk/forms/conftest.py	Added synchronous and asynchronous fixtures that publish previously created forms before returning them. Both invoke the publish operation and depend on the existing form fixtures.
Test Enablement and Refactoring tests/e2e/helpdesk/forms/test_sync_forms.py, tests/e2e/helpdesk/forms/test_async_forms.py	Removed @pytest.mark.skip decorators from multiple test functions to activate execution. Updated test_unpublish_form in both files to use the new published form fixtures and replaced generic non-null assertions with explicit status validation (result.status == "Unpublished").

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• softwareone-platform/mpt-api-python-client#245: Implemented the FormsService publish/unpublish API operations and added initial form e2e test scaffolding that these changes build upon.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Jira Issue Key In Title	✅ Passed	PR title contains exactly one valid Jira issue key MPT-19482 in the required MPT-XXXX format.
Test Coverage Required	✅ Passed	The PR modifies only test files within the tests/ folder. No code files outside the tests/ directory are being modified.
Single Commit Required	✅ Passed	The pull request contains exactly one commit, which maintains a clean git history and makes changes easy to follow and review.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud