Fix broken HERMES DOI in plugin marketplace #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a more reliable method of detecting HERMES DOIs to the `hermes-marketplace` command. This detection mechanism is used to figure out which plugins are "builtin" (via `schema:isPartOf`).
Contributor
Author
|
TODO: Add tests for |
Contributor
Author
|
@poikilotherm tests were added. |
nheeb
approved these changes
Apr 22, 2025
Contributor
nheeb
left a comment
nheeb
left a comment
There was a problem hiding this comment.
The changes are understandable and valid 👍
Contributor
Author
|
Thanks! This has been open for a while now. So I'll merge it now. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the broken HERMES DOI used all over the plugin marketplace (#326).
Additionally, it adds a more reliable method of detecting builtin plugins.
BREAKING CHANGE: By changing the JSON-LD metadata in the docs page, this change breaks the
hermes-marketplacecommand in HERMES v0.8.1 and v0.9.0. The command will continue to run successfully, but it will not be able to detect "builtin" plugins any more, and simply show them without a location.Closes #326.