Skip to content

fix(settings): trigger variable watcher on save#4451

Merged
sogehige merged 2 commits into
masterfrom
varWatch
Dec 20, 2020
Merged

fix(settings): trigger variable watcher on save#4451
sogehige merged 2 commits into
masterfrom
varWatch

Conversation

@sogehige
Copy link
Copy Markdown
Collaborator

CHECKLIST

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2020

Codecov Report

Merging #4451 (c3c64e5) into master (7553d88) will decrease coverage by 0.15%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4451      +/-   ##
==========================================
- Coverage   55.73%   55.58%   -0.16%     
==========================================
  Files         135      135              
  Lines       14347    14368      +21     
  Branches     2897     2904       +7     
==========================================
- Hits         7996     7986      -10     
- Misses       6351     6382      +31     
Flag Coverage Δ
mysql 55.34% <53.33%> (-0.04%) ⬇️
postgres 55.36% <53.33%> (-0.18%) ⬇️
sqlite 55.38% <53.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/bot/helpers/socket.ts 100.00% <ø> (ø)
src/bot/panel.ts 30.37% <20.00%> (-0.02%) ⬇️
src/bot/_interface.ts 56.56% <50.00%> (-0.04%) ⬇️
src/bot/watchers.ts 80.55% <68.00%> (-6.95%) ⬇️
src/bot/general.ts 29.71% <100.00%> (+0.51%) ⬆️
src/bot/main.ts 73.63% <100.00%> (ø)
src/bot/helpers/permissions.ts 92.30% <0.00%> (-7.70%) ⬇️
src/bot/systems/points.ts 62.81% <0.00%> (-7.19%) ⬇️
src/bot/permissions.ts 65.39% <0.00%> (-2.43%) ⬇️
src/bot/systems/moderation.ts 93.47% <0.00%> (-1.04%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7553d88...c3c64e5. Read the comment docs.

@sogehige sogehige merged commit 874d2ff into master Dec 20, 2020
@sogehige sogehige deleted the varWatch branch December 20, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant