Skip to content

feat(integration): implement obs-websocket#4569

Merged
sogehige merged 38 commits into
masterfrom
com_245
Feb 4, 2021
Merged

feat(integration): implement obs-websocket#4569
sogehige merged 38 commits into
masterfrom
com_245

Conversation

@sogehige
Copy link
Copy Markdown
Collaborator

@sogehige sogehige commented Jan 26, 2021

CHECKLIST
  • toggle to use overlay or direct connect
  • check if event id is currently running and throw away events when in progress
  • run advancedMode

https://github.com/Palakis/obs-websocket/blob/4.x-current/docs/generated/protocol.md

  • events:
    • ReorderSceneItems
    • GetMediaSourcesList -> Media Control Unreleased
    • SetVolume
    • SetMute
    • StartRecording
    • StopRecording
    • PauseRecording
    • ResumeRecording
    • StartStopReplayBuffer
    • StartReplayBuffer
    • StopReplayBuffer
    • SaveReplayBuffer
  • bot listener events:
    • scene changed
    • events from overlay should be guarded by specifying id or link of overlay in event listener editation, so some random malicious events cannot be sent.
  • overlay and direct connect should share code (should be simple with functional approach)
  • overlay should run correctly advanced mode and simple mode
  • command in UI table should be correct
  • I read contributing docs

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 26, 2021

Codecov Report

Merging #4569 (8c39a11) into master (f41bcd3) will decrease coverage by 0.74%.
The diff coverage is 34.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4569      +/-   ##
==========================================
- Coverage   58.72%   57.97%   -0.75%     
==========================================
  Files         257      268      +11     
  Lines       15296    15704     +408     
  Branches     2956     3017      +61     
==========================================
+ Hits         8982     9105     +123     
- Misses       6314     6599     +285     
Flag Coverage Δ
mysql 57.53% <34.29%> (-0.86%) ⬇️
postgres 57.83% <34.12%> (-0.45%) ⬇️
sqlite 57.31% <33.44%> (-1.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/bot/filters/price.ts 62.50% <0.00%> (ø)
src/bot/games/heist.ts 100.00% <ø> (ø)
src/bot/general.ts 40.98% <0.00%> (ø)
src/bot/helpers/api/calls.ts 76.00% <ø> (ø)
src/bot/helpers/commons/getBotSender.ts 100.00% <ø> (ø)
src/bot/helpers/commons/getOwnerAsSender.ts 100.00% <ø> (ø)
src/bot/helpers/events/emitter.ts 100.00% <ø> (ø)
...ot/helpers/permissions/getUserHighestPermission.ts 93.33% <ø> (ø)
src/bot/integrations/discord.ts 19.68% <0.00%> (ø)
src/bot/integrations/donationalerts.ts 33.70% <0.00%> (ø)
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f41bcd3...8c39a11. Read the comment docs.

@sogehige sogehige changed the title WIP obs-websocket feat(integration): implement obs-websocket Feb 4, 2021
@sogehige sogehige merged commit c37b84c into master Feb 4, 2021
@sogehige sogehige deleted the com_245 branch February 4, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant