Skip to content

feat(goals): add support for interval goals subs/follow/tips/bits#4804

Merged
sogehige merged 4 commits into
masterfrom
4800
Sep 3, 2021
Merged

feat(goals): add support for interval goals subs/follow/tips/bits#4804
sogehige merged 4 commits into
masterfrom
4800

Conversation

@sogehige
Copy link
Copy Markdown
Collaborator

@sogehige sogehige commented Sep 3, 2021

Fixes #4800

CHECKLIST

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 3, 2021

Codecov Report

Merging #4804 (4791527) into master (71153a8) will decrease coverage by 2.96%.
The diff coverage is 41.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4804      +/-   ##
==========================================
- Coverage   53.56%   50.60%   -2.97%     
==========================================
  Files         477      555      +78     
  Lines       20947    22556    +1609     
  Branches     3347     3428      +81     
==========================================
+ Hits        11220    11414     +194     
- Misses       9727    11142    +1415     
Flag Coverage Δ
mysql 53.15% <36.92%> (+30.36%) ⬆️
postgres 53.46% <36.92%> (-0.08%) ⬇️
sqlite 56.34% <44.04%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/database/entity/goal.ts 100.00% <ø> (ø)
...on/mysql/12.0.x/1592557005214-fontMissingShadow.ts 8.33% <0.00%> (ø)
...postgres/12.0.x/1592557005214-fontMissingShadow.ts 8.33% <0.00%> (ø)
src/api/registries/goals.ts 24.48% <7.69%> (-6.07%) ⬇️
...n/mysql/13.0.x/1626478375130-addIntervalToGoals.ts 33.33% <33.33%> (ø)
...ostgres/13.0.x/1626478375130-addIntervalToGoals.ts 33.33% <33.33%> (ø)
src/helpers/goals/recountIntervals.ts 41.02% <41.02%> (ø)
...n/sqlite/12.0.x/1592557005214-fontMissingShadow.ts 33.33% <50.00%> (ø)
.../sqlite/13.0.x/1626478375130-addIntervalToGoals.ts 54.16% <54.16%> (ø)
...gration/sqlite/13.0.x/1622378375126-goalsUpdate.ts 51.42% <100.00%> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71153a8...4791527. Read the comment docs.

@sogehige sogehige merged commit 39023ff into master Sep 3, 2021
@sogehige sogehige deleted the 4800 branch September 3, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add goals with daily vairables

1 participant