added noetic Dockerfile

[rtarun1]

Created Noetic Dockerfile for old robots like Husky and P3DX which still only work ROS 1 Noetic. It shall be mostly useful for RPN or MR students

[Srindot]

No instance of the base image
FROM ubuntu:focal
and syntax error in the dockerfile.

[soham2560]

@Srindot I believe ubuntu:focal is a proper base image?

where did you encounter the syntax error?

[soham2560]

@rtarun1 I am unable to build, might be a local issue

 > [ 4/10] RUN set -eux;     key='C1CF6E31E6BADE8868B172B4F42ED6FBAB17C654';     export GNUPGHOME="$(mktemp -d)";     gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key";     mkdir -p /usr/share/keyrings;     gpg --batch --export "$key" > /usr/share/keyrings/ros1-latest-archive-keyring.gpg;     gpgconf --kill all;     rm -rf "$GNUPGHOME":                                   
0.122 + key=C1CF6E31E6BADE8868B172B4F42ED6FBAB17C654                                                                             
0.122 ++ mktemp -d                                                                                                               
0.123 + export GNUPGHOME=/tmp/tmp.juA4MS4amO
0.123 + GNUPGHOME=/tmp/tmp.juA4MS4amO
0.123 + gpg --batch --keyserver keyserver.ubuntu.com --recv-keys C1CF6E31E6BADE8868B172B4F42ED6FBAB17C654
0.125 gpg: keybox '/tmp/tmp.juA4MS4amO/pubring.kbx' created
34.81 gpg: keyserver receive failed: Connection timed out

did you have a successful run with this?

[soham2560]

@rtarun1 can you also add a test command in the PR description so reviewers can test this easily? or provide a sample .devcontainer conifg

[rtarun1]

@soham2560 I guess the build error is due to iiit wifi, I was able to build the image using my personal hotspot, and I was also able to open a container and all seem to be normal for me.

Here is a example docker run command

docker run -it \
--rm
--privileged
--cap-add=SYS_NICE
--ulimit rtprio=99
--ulimit rttime=-1
--ulimit memlock=8428281856
--cap-add=all
--security-opt seccomp:unconfined
--security-opt apparmor:unconfined
--volume=/dev:/dev
--net=host
--ipc=host
-e DISPLAY="${DISPLAY}"
-e WAYLAND_DISPLAY="${WAYLAND_DISPLAY}"
-e XDG_RUNTIME_DIR="${XDG_RUNTIME_DIR}"
-e PULSE_SERVER="${PULSE_SERVER}"
-e QT_X11_NO_MITSHM="1"
-e LIBGL_ALWAYS_SOFTWARE="1"
--entrypoint /bin/bash
--name noetic
<image_name>

[rtarun1]

@soham2560 Everything is working, also tested with hardware! P3DX-Docker, checkout this repo, P3DX right now only working on ROS noetic, will also be using this for husky.

[rtarun1]

Tested the image with Husky hardware, it is working! Husky repo

[soham2560]

can you have a look at this?

also I noticed a couple of things

• we are not adding anyhting to ~/.bashrc like in the other image, is there no need?
• there also does not seem to be any steps for argcompletion etc, any reason?

[soham2560]

Also I guess the repo name has to be changed now to include ros1 :)

[rtarun1]

can you have a look at this?

also I noticed a couple of things

• we are not adding anyhting to ~/.bashrc like in the other image, is there no need?
• there also does not seem to be any steps for argcompletion etc, any reason?

• Added sourcing ROS inside bashrc, Refer 7289362
• argcompletion is not required in ros1.

[rtarun1]

Also I guess the repo name has to be changed now to include ros1 :)

Or let it be ironic, lol

[soham2560]

Or let it be ironic, lol

lol, I'll change next time there are no active PRs to avoid issues for contributors

[soham2560]

Added sourcing ROS inside bashrc, Refer 7289362
argcompletion is not required in ros1.

the changes look good to me! last thing left, can you add the noetic image to the readme, and if you want, the PX3D and Husky repos to the examples

[rtarun1]

Added sourcing ROS inside bashrc, Refer 7289362
argcompletion is not required in ros1.

the changes look good to me! last thing left, can you add the noetic image to the readme, and if you want, the PX3D and Husky repos to the examples

Done, Please refer 97f75c3

[soham2560]

Done, Please refer 97f75c3

could not be better! LGTM, thanks for the contribution!