Fix deadline auto-pin overriding user intent#50
Merged
Conversation
- Remove all auto-pin from reload, refresh, and "New set" paths - Auto-pin only on first generation of the day (weight boost) and setting a deadline from All Tasks (direct pin via pinNewTask) - New DB table todays_five_deadline_suppressed (v23) tracks blocked pins - Immediate pin from _editSchedule with accurate snackbar messages - Fix isLeaf check (was using provider.tasks instead of DB query) - Fix bottom sheet overflow (SingleChildScrollView) - Enforce maxPins cap in all remaining auto-pin paths - Update manual-test skill rules and tests Pending: manual testing on device (see memory/wip_deadline_autopin.md) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pin DB write now happens before updateTaskDeadline (which triggers notifyListeners → refreshSnapshots → _persist, overwriting the pin). Also rename /add-tests → /add-auto-tests and /test-all → /test-suite for clarity alongside /manual-test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6 tests covering suppressDeadlineAutoPin, unsuppressDeadlineAutoPin, getDeadlineSuppressedIds: idempotent insert, per-date isolation, unsuppress, empty for unknown date, cleared by deleteAllLocalData. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ppression rows Suppression DB writes in _togglePinFromSheet now have .catchError to surface failures in debug mode. Added purgeOldDeadlineSuppressed to clean up rows from past dates on each load, preventing unbounded table growth. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_reloadFromDb,_refreshTodaysTasks, and_generateNewSet— auto-pin now only happens when explicitly setting a deadline from All Tasks via Schedule dialogupdateTaskDeadline(which triggersnotifyListeners→refreshSnapshots→_persist, which was overwriting the pin)todays_five_deadline_suppressedtable (v23 migration) tracks user unpins so deadline tasks aren't re-pinned across reloadsSingleChildScrollViewwrap in task card bottom sheet/add-tests→/add-auto-tests,/test-all→/test-suiteTest plan
🤖 Generated with Claude Code