Skip to content

Fix deadline tasks not appearing in Today's 5#52

Merged
sohamM97 merged 2 commits intomainfrom
bugfix/scheduled-today-not-pinned
Mar 22, 2026
Merged

Fix deadline tasks not appearing in Today's 5#52
sohamM97 merged 2 commits intomainfrom
bugfix/scheduled-today-not-pinned

Conversation

@sohamM97
Copy link
Copy Markdown
Owner

Summary

  • Auto-pin on first generation: Deadline-due tasks (both "due by" and "on") are now auto-pinned when Today's 5 is first generated for the day. Not on rerolls (prevents whack-a-mole). Only exact-today deadlines — overdue handled by weight boost ramp-down.
  • "On" deadline weight boost: "On" type deadlines now get weight boost (8x) on the day itself and when overdue. Silent before the date (no ramp-up), matching the design intent of "silent until the date, then surface."
  • Pin in-set tasks on deadline set: Setting deadline to today for a task already in Today's 5 now pins it (was: showed "already in Today's 5" without pinning).
  • Debug midnight rollover: Moon icon button (debug builds only) simulates midnight rollover for testing.

Test plan

  • 33 new automated tests (13 DB, 6 widget, 9 model, 5 Firestore)
  • Full test suite passes (exit 0)
  • Manual tests on Linux: first-gen auto-pin, suppression, whack-a-mole prevention, in-set pinning, pin/complete regression
  • Phone testing

🤖 Generated with Claude Code

… weight boost for "on" type

Two bugs fixed:
1. "On" deadline tasks got neither weight boost nor auto-pin when their
   date arrived, making them unlikely to appear in Today's 5.
2. Tasks already in Today's 5 weren't pinned when user set deadline to
   today (showed "already in Today's 5" without pinning).

Changes:
- Auto-pin deadline-due tasks on first generation of the day (not on
  rerolls, preventing whack-a-mole). Only exact-today deadlines, not
  overdue (overdue handled by weight boost ramp-down).
- "On" deadlines now get weight boost on day-of and when overdue
  (silent before the date, same as "due by" on the day itself).
- Pin in-set tasks when user sets deadline to today from All Tasks.
- Debug midnight rollover button (moon icon, debug builds only).
- Comprehensive tests: 13 new DB tests, 6 widget tests, 9 model
  tests, 5 Firestore tests.
- Updated algorithm doc with deadline type table and ramp-down details.
- Skill improvements: bugfix comments, flow change confirmation,
  test-suite branch detection, manual-test concrete test cases.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sohamM97 sohamM97 merged commit a85745b into main Mar 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant