Skip to content

Starred view: colour-only priority, dependency ordering#63

Merged
sohamM97 merged 2 commits intomainfrom
feature/starred-view-enhancements
Mar 30, 2026
Merged

Starred view: colour-only priority, dependency ordering#63
sohamM97 merged 2 commits intomainfrom
feature/starred-view-enhancements

Conversation

@sohamM97
Copy link
Copy Markdown
Owner

Summary

  • Remove bold from high-priority children in starred views — accent colour tint alone provides enough visual distinction
  • Reorder children by dependency chains so blocked tasks appear after their blocker, matching All Tasks view
  • Applied in both tree preview cards and expanded dialog
  • 12 new reorder tests, 6 updated childTextStyle tests

Test plan

  • 1257 automated tests pass (12 new reorder + 6 updated style)
  • Manual test: high-priority children show colour only, no bold
  • Manual test: blocked tasks appear after blocker in tree preview
  • Manual test: blocked tasks appear after blocker in expanded dialog
  • Manual test: ordering matches All Tasks view

🤖 Generated with Claude Code

Remove bold from high-priority children in starred views — colour tint
alone is enough visual distinction. Reorder children by dependency chains
so blocked tasks appear after their blocker, matching All Tasks view.
Applied in both tree preview and expanded dialog. 12 new reorder tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@claude
Copy link
Copy Markdown

claude Bot commented Mar 30, 2026

Code review

Issue found in docs/UI_VIEWS.md: incorrect function name

The Expanded dialog description references _reorderByDependencyChains() (with a leading underscore), but the actual function introduced by this PR is the public reorderByDependencyChains() (no underscore). In Dart, a leading underscore denotes a private symbol — _reorderByDependencyChains does not exist in starred_screen.dart; the only function with that private name is an unrelated method in task_provider.dart.

Per CLAUDE.md: "Verify before documenting. Before writing any factual claim in a doc (docs/, CHANGELOG, comments), verify it exists in the codebase first."

The actual function is defined here:

final treeEntries = await Future.wait(starred.map((task) async {
final children = await provider.getChildren(task.id!);
var allActive = children
.where((c) => c.completedAt == null && c.skippedAt == null)

Fix: Change _reorderByDependencyChains() to reorderByDependencyChains() on this line of docs/UI_VIEWS.md.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sohamM97 sohamM97 merged commit 6d5646f into main Mar 30, 2026
2 checks passed
@sohamM97 sohamM97 deleted the feature/starred-view-enhancements branch March 30, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant