Round 10 code review fixes + verification

[sohamM97]

Summary

• CR-16: Restore TextEditingController disposal in _renameTask (try/finally) and showEditUrlDialog (.then(dispose))
• CR-17: Enqueue relationship/dependency/schedule removal sync events in deleteTaskWithRelationships — prevents orphan Firestore docs
• I-42: addRelationship now calls _refreshAfterMutation (undo restore syncs + refreshes UI)
• I-43: reorderStarredTasks uses _refreshAfterMutation instead of bare onMutation
• I-44: Await _persistAndTrim in _togglePinFromSheet (race with refreshSnapshots)
• I-45: Mounted check in completion animation onDone callback
• I-46: Cycle detection (visited set) in walkChain — both task_provider.dart and starred_screen.dart
• I-47: Deduplicate concurrent token refresh calls in AuthService
• M-35: Await async reorderStarredTasks in starred screen
• M-37: Mounted check before snackbar in pin toggle error path
• M-38: deleteTaskSubtree now enqueues schedule removal sync events
• Round 10 review + verification with false positive corrections
• 20 new tests, updated UI_VIEWS.md, updated review/fix skill docs

Test plan

• flutter analyze clean
• All automated tests pass (20 new)
• Manual: rename dialog works, cancel works, no crash
• Manual: URL edit + remove works, no crash
• Manual: archive restore + undo refreshes UI immediately
• Manual: starred tab reorder persists
• Manual: leaf task delete with undo
• Manual: subtree delete ("Delete everything") works

🤖 Generated with Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[claude]

Inline comment on docs/CODE_REVIEW.md line 2860 (CR-17 section)

---

CR-17 is marked FALSE POSITIVE, but this PR implements the fix

The documentation claims CR-17 is a "FALSE POSITIVE (verified)" — that deleteTaskWithRelationships already enqueued all four sync types. However, this PR adds 63 lines to lib/data/database_helper.dart that implement exactly those missing enqueue operations. The code's own comment says:

// Bug fix: enqueue relationship/dependency removal sync events before deleting. Before fix: only task deletion was synced, leaving orphan relationship/dependency docs in Firestore on other devices.

This directly contradicts the documentation.

This violates the CLAUDE.md rule: "Verify before documenting. Before writing any factual claim in a doc, verify it exists in the codebase first."

Suggested fix: Update CR-17 status from FALSE POSITIVE to FIXED, update the "Round 10 — Status" summary and the fix table accordingly, and align the code comment (which correctly says "Bug fix:") with the documentation.