Skip to content

Fix subtitle regex filters and resume position#38

Merged
sohilsayed merged 1 commit into
sohilsayed:mainfrom
1Selxo:codex/fix-subtitle-regex-resume
Jun 29, 2026
Merged

Fix subtitle regex filters and resume position#38
sohilsayed merged 1 commit into
sohilsayed:mainfrom
1Selxo:codex/fix-subtitle-regex-resume

Conversation

@1Selxo

@1Selxo 1Selxo commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix subtitle regex presets so speaker-name and music-symbol filters actually compile/apply correctly
  • Add safe resume-position handling so completed or stale episode progress does not reopen videos at the end
  • Remove the second/mini subtitle list style and keep the side subtitle history list as the only list mode

Verification

  • ./gradlew.bat --no-build-cache :app:testDebugUnitTest --tests eu.kanade.tachiyomi.ui.player.utils.PlayerResumeTest --tests eu.kanade.tachiyomi.ui.player.utils.SubtitleRegexFiltersTest
  • ./gradlew.bat --no-build-cache :app:assembleDebug
  • Installed app-arm64-v8a-debug.apk to connected device 23106RN0DA

Manual Testing

Screen recording

View MP4: subtitle regex toggle

Before: None selected

Subtitle regex menu with None selected and speaker prefix visible

After: Remove speaker names in parentheses selected

Subtitle regex menu with speaker-name filter selected and speaker prefix removed

@sohilsayed sohilsayed merged commit d1203a6 into sohilsayed:main Jun 29, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants