docs(tags): complete delete_tag_definition docs + regression tests#67
Merged
Conversation
Cherry-picked the genuine bits from codex PR #66, dropping that PR's v1.6.6→v1.7.0 doc rewrites and the wire-trace-v166/v167→v170-* probe renames (iteration markers, not release versions — rejected the same way as #62/#64). Real fixes the audit's docs lane missed: - README.md tool table: Tags row now lists delete_tag_definition (was added to the catalog but not the README table). - src/capsule/cache.ts: header + invalidateByPrefix doc comments now name delete_tag_definition as a third tag-mutating tool that drops the list_tags cache (accurate — the handler does call invalidateByPrefix), and generalize "/tags" → "/<entity>/tags". Test coverage: - tests/cache.test.ts: delete_tag_definition invalidates the cached list_tags response. - tests/entries.test.ts: a merged-timeline window that CROSSES the 100-entry ceiling returns the in-ceiling tail and ends the feed (complements the #65 boundary test with the partial-window case). Plus a sharper PAGINATION CAVEAT wording (distinguishes crossing-window truncation from beyond-ceiling empty) — kept the v1.6.6 provenance. Closes #66 (cherry-picked clean). 538 → 540 tests. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks the genuine bits from codex #66, dropping that PR's v1.6.6→v1.7.0 doc rewrites and the
wire-trace-v166/v167 → v170-*probe renames (iteration markers, not release versions — same rejection as #62/#64).Real gaps my audit's docs lane missed:
README.mdtool table — the Tags row listedadd_tag,remove_tag_by_idbut notdelete_tag_definition(added to the catalog in this release but not the table).src/capsule/cache.ts— the cache-module doc comments named onlyadd_tag/remove_tag_by_idas cache-invalidating;delete_tag_definitionalso callsinvalidateByPrefix, so the comment was inaccurate. Now correct, and generalizes/tags→/<entity>/tags.Added coverage:
tests/cache.test.ts:delete_tag_definitioninvalidates the cachedlist_tagsresponse.tests/entries.test.ts: a merged-timeline window that crosses the 100-entry ceiling returns the in-ceiling tail (25 entries) and ends the feed — complements the chore: pre-v1.7.0 audit fixes #65 boundary test with the partial-window case.Plus a sharper PAGINATION CAVEAT wording (distinguishes crossing-window truncation from beyond-ceiling empty), with the v1.6.6 provenance preserved.
Dropped from #66 (churn)
wire-trace-v166.ts → v170-entries.ts,v167.ts → v170-gaps.ts.v1.6.6 → v1.7.0rewrites across NOTES/DESIGN/OPTIMIZATIONS/CHANGELOG/entries.ts/tags.ts (including a worse "v1.7.0 release-candidate regression" phrasing).Closes #66.
Test plan
entries.ts(<ceiling logic from chore: pre-v1.7.0 audit fixes #65)v1.7.0/v170churn pulled in (git grepclean); v1.6.6 provenance preserved🤖 Generated with Claude Code