Bump rubocop from 1.32.0 to 1.34.0#42
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.32.0 to 1.34.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.32.0...v1.34.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Author
|
Superseded by #44. |
pull Bot
pushed a commit
that referenced
this pull request
Feb 19, 2026
…figurable add OPENPROJECT_HOST
pull Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
Cover the changed behavior where subjectWithId now delegates to displayIdWithHash instead of inlining the numeric id. Tests verify semantic mode output (#PROJ-7), classic mode (#42), and no suffix for new resources.
pull Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
Semantic identifiers (e.g. PROJ-42) are self-describing and should not be prefixed with #. Only classic numeric IDs retain the hash prefix (e.g. #42). This matches Jira's convention and PR review feedback. The detection uses a simple regex check: if the displayId contains any letter, it's semantic (no hash); otherwise it's classic (hash prefix).
pull Bot
pushed a commit
that referenced
this pull request
Apr 23, 2026
The reporting filter widget pre-populates opce-autocompleter with
plain hashes ({id:, name:}). When the autocompleter template switched
from `#{item.id}` to `{{ item.formattedId }}`, those hashes had no
formattedId key and the ID prefix disappeared from the selected-value
label, breaking work_package_costlog_spec and time_entry_activity_spec.
Extend Widget::Filters::WorkPackage#map_filter_values to emit
formattedId, displayId, and subject alongside id/name so the
autocompleter template has the data it needs.
Centralise the formatting logic in a new WorkPackage#formatted_id
model method, mirroring the frontend formatWorkPackageId helper:
semantic identifiers pass through (PROJ-42); numeric ids are
prefixed with # (#42).
pull Bot
pushed a commit
that referenced
this pull request
Apr 23, 2026
The shared info line rendered hard-coded `#<numeric-id>` instead of respecting the semantic identifier setting. Use WorkPackage#formatted_id (added alongside the autocompleter/global-search work) so Relations, hover cards, version widgets, backlogs, meetings, and time tracking all pick up semantic IDs like "PROJ-42" in semantic mode, "#42" in classic mode.
pull Bot
pushed a commit
that referenced
this pull request
Apr 23, 2026
Adds two test layers that would have caught the plain-hash bug the widget fix addressed: - Widget unit spec (modules/reporting/spec/lib/widget/filters/work_package_spec.rb) asserts map_filter_values emits id/displayId/formattedId/subject/name with the right values in both modes. Fast feedback, pins the Rails-to-Angular contract the autocompleter template depends on. - work_package_costlog_spec is now parameterised over classic and semantic modes via shared_examples, asserting the pre-populated autocompleter renders "#42 subject" and "MYPROJ-1 subject" respectively. End-to-end confidence that the widget, template, and formattedId helper agree in a real browser.
pull Bot
pushed a commit
that referenced
this pull request
May 7, 2026
The page <title> on the WP show view is built from #infoline; with a
hardcoded "##{id}" it disagreed with every other surface in semantic
mode (numeric primary key vs. "PROJ-1"). formatted_id resolves to "#42"
in classic mode and "PROJ-1" in semantic, mirroring the shape already
used by #to_s and link_to_work_package.
pull Bot
pushed a commit
that referenced
this pull request
May 14, 2026
…antic ids
The autocomplete dropdown in CKEditor renders each result with
`item.name = wp.to_s`, and `to_s` hardcoded `##{id}` — so a semantic-mode
search for `#KSTP-2` resolved correctly but the dropdown row showed
`Task opf#10244: Subject` instead of `Task KSTP-2: Subject`.
Switch to `formatted_id`, which already produces the user-facing form in
both modes (`PROJ-7` semantic, `#42` classic). The other caller — the
delete-dialog component — benefits from the same mode awareness.
pull Bot
pushed a commit
that referenced
this pull request
May 14, 2026
The activity feed renders an automatic entry whenever a parent / child /
predecessor / related work package change cascades dates onto the
current WP. Both render paths spoke numeric ids:
- The plain-text branch (used for the API JSON) hardcoded `##{id}`.
- The HTML branch went through `link_to_work_package`, which built the
visible link label as `Type ##{id}: subject`.
Both now use `formatted_id`, which produces `PROJ-7` in semantic mode
and `#42` in classic — same shape, mode-aware. The link href was
already mode-correct via `to_param`; only the visible label needed the
swap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 1.32.0 to 1.34.0.
Release notes
Sourced from rubocop's releases.
... (truncated)
Changelog
Sourced from rubocop's changelog.
Commits
a407f64Cut 1.3401c3b20Update Changelog1db2aaeSupport Bundler-like namespaced feature on require config88af469Merge pull request #10886 from dvandersluis/issue/1088167f3055Merge pull request #10885 from dvandersluis/issue/10883838ec41[Fix #10883] FixStyle/RedundantParenthesesto be able to detect offenses a...64cdfad[Fix #10881] FixStyle/SoleNestedConditionalto properly wrapblockand `...eaec469Merge pull request #10887 from dvandersluis/lint/shadowed-exceptionf304479Merge pull request #10888 from dvandersluis/issue/107732ace9ef[Fix #10773] Updateparsergem to >= 3.1.2.1.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)