Rename all ProfilePanels into ProfileMenuItems

Summary: Ref T11957.

Test Plan:
  - Viewed an existing project profile.
  - Viewed a user profile.
  - Created a new project.
  - Edited a profile menu.
  - Added new profile items.
  - Grepped for renamed symbols.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11957

Differential Revision: https://secure.phabricator.com/D17028

Author: epriestley

src/__phutil_library_map__.php

@@ -627,18 +627,18 @@ protected function getQueryRoutePattern($base = null) {
     return $base.'(?:query/(?P<queryKey>[^/]+)/)?';
   }
 
-  protected function getPanelRouting($controller) {
+  protected function getProfileMenuRouting($controller) {
     $edit_route = $this->getEditRoutePattern();
 
     return array(
-      '(?P<panelAction>view)/(?P<panelID>[^/]+)/' => $controller,
-      '(?P<panelAction>hide)/(?P<panelID>[^/]+)/' => $controller,
-      '(?P<panelAction>default)/(?P<panelID>[^/]+)/' => $controller,
-      '(?P<panelAction>configure)/' => $controller,
-      '(?P<panelAction>reorder)/' => $controller,
-      '(?P<panelAction>edit)/'.$edit_route => $controller,
-      '(?P<panelAction>new)/(?<panelKey>[^/]+)/'.$edit_route => $controller,
-      '(?P<panelAction>builtin)/(?<panelID>[^/]+)/'.$edit_route
+      '(?P<itemAction>view)/(?P<itemID>[^/]+)/' => $controller,
+      '(?P<itemAction>hide)/(?P<itemID>[^/]+)/' => $controller,
+      '(?P<itemAction>default)/(?P<itemID>[^/]+)/' => $controller,
+      '(?P<itemAction>configure)/' => $controller,
+      '(?P<itemAction>reorder)/' => $controller,
+      '(?P<itemAction>edit)/'.$edit_route => $controller,
+      '(?P<itemAction>new)/(?<itemKey>[^/]+)/'.$edit_route => $controller,
+      '(?P<itemAction>builtin)/(?<itemID>[^/]+)/'.$edit_route
         => $controller,
     );
   }

src/applications/base/PhabricatorApplication.php

@@ -71,8 +71,8 @@ public function getRoutes() {
         ),
       '/p/(?P<username>[\w._-]+)/' => array(
         '' => 'PhabricatorPeopleProfileViewController',
-        'panel/'
-          => $this->getPanelRouting('PhabricatorPeopleProfilePanelController'),
+        'item/' => $this->getProfileMenuRouting(
+          'PhabricatorPeopleProfileMenuController'),
       ),
     );
   }

src/applications/people/application/PhabricatorPeopleApplication.php

@@ -85,7 +85,7 @@ public function handleRequest(AphrontRequest $request) {
     $crumbs->setBorder(true);
 
     $nav = $this->getProfileMenu();
-    $nav->selectFilter(PhabricatorPeopleProfileMenuEngine::PANEL_MANAGE);
+    $nav->selectFilter(PhabricatorPeopleProfileMenuEngine::ITEM_MANAGE);
 
     $header = id(new PHUIHeaderView())
       ->setHeader(pht('Edit Profile: %s', $user->getFullName()))

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

@@ -43,7 +43,7 @@ public function handleRequest(AphrontRequest $request) {
     $name = $user->getUsername();
 
     $nav = $this->getProfileMenu();
-    $nav->selectFilter(PhabricatorPeopleProfileMenuEngine::PANEL_MANAGE);
+    $nav->selectFilter(PhabricatorPeopleProfileMenuEngine::ITEM_MANAGE);
 
     $timeline = $this->buildTransactionTimeline(
       $user,

src/applications/people/controller/PhabricatorPeopleProfileManageController.php

@@ -256,7 +256,7 @@ public function handleRequest(AphrontRequest $request) {
     $crumbs->setBorder(true);
 
     $nav = $this->getProfileMenu();
-    $nav->selectFilter(PhabricatorPeopleProfileMenuEngine::PANEL_MANAGE);
+    $nav->selectFilter(PhabricatorPeopleProfileMenuEngine::ITEM_MANAGE);
 
     $header = id(new PHUIHeaderView())
       ->setHeader(pht('Edit Profile Picture'))

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

@@ -78,7 +78,7 @@ public function handleRequest(AphrontRequest $request) {
         ));
 
     $nav = $this->getProfileMenu();
-    $nav->selectFilter(PhabricatorPeopleProfileMenuEngine::PANEL_PROFILE);
+    $nav->selectFilter(PhabricatorPeopleProfileMenuEngine::ITEM_PROFILE);
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->setBorder(true);

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

@@ -3,28 +3,28 @@
 final class PhabricatorPeopleProfileMenuEngine
   extends PhabricatorProfileMenuEngine {
 
-  const PANEL_PROFILE = 'people.profile';
-  const PANEL_MANAGE = 'people.manage';
+  const ITEM_PROFILE = 'people.profile';
+  const ITEM_MANAGE = 'people.manage';
 
   protected function isMenuEngineConfigurable() {
     return false;
   }
 
-  protected function getPanelURI($path) {
+  protected function getItemURI($path) {
     $user = $this->getProfileObject();
     $username = $user->getUsername();
     $username = phutil_escape_uri($username);
-    return "/p/{$username}/panel/{$path}";
+    return "/p/{$username}/item/{$path}";
   }
 
-  protected function getBuiltinProfilePanels($object) {
+  protected function getBuiltinProfileItems($object) {
     $viewer = $this->getViewer();
 
-    $panels = array();
+    $items = array();
 
-    $panels[] = $this->newPanel()
-      ->setBuiltinKey(self::PANEL_PROFILE)
-      ->setMenuItemKey(PhabricatorPeopleDetailsProfilePanel::PANELKEY);
+    $items[] = $this->newItem()
+      ->setBuiltinKey(self::ITEM_PROFILE)
+      ->setMenuItemKey(PhabricatorPeopleDetailsProfileMenuItem::MENUITEMKEY);
 
     $have_maniphest = PhabricatorApplication::isClassInstalledForViewer(
       'PhabricatorManiphestApplication',
@@ -34,9 +34,9 @@ protected function getBuiltinProfilePanels($object) {
         '/maniphest/?statuses=open()&assigned=%s#R',
         $object->getPHID());
 
-      $panels[] = $this->newPanel()
+      $items[] = $this->newItem()
         ->setBuiltinKey('tasks')
-        ->setMenuItemKey(PhabricatorLinkProfilePanel::PANELKEY)
+        ->setMenuItemKey(PhabricatorLinkProfileMenuItem::MENUITEMKEY)
         ->setMenuItemProperty('icon', 'maniphest')
         ->setMenuItemProperty('name', pht('Open Tasks'))
         ->setMenuItemProperty('uri', $uri);
@@ -50,9 +50,9 @@ protected function getBuiltinProfilePanels($object) {
         '/differential/?authors=%s#R',
         $object->getPHID());
 
-      $panels[] = $this->newPanel()
+      $items[] = $this->newItem()
         ->setBuiltinKey('revisions')
-        ->setMenuItemKey(PhabricatorLinkProfilePanel::PANELKEY)
+        ->setMenuItemKey(PhabricatorLinkProfileMenuItem::MENUITEMKEY)
         ->setMenuItemProperty('icon', 'differential')
         ->setMenuItemProperty('name', pht('Revisions'))
         ->setMenuItemProperty('uri', $uri);
@@ -66,19 +66,19 @@ protected function getBuiltinProfilePanels($object) {
         '/audit/?authors=%s#R',
         $object->getPHID());
 
-      $panels[] = $this->newPanel()
+      $items[] = $this->newItem()
         ->setBuiltinKey('commits')
-        ->setMenuItemKey(PhabricatorLinkProfilePanel::PANELKEY)
+        ->setMenuItemKey(PhabricatorLinkProfileMenuItem::MENUITEMKEY)
         ->setMenuItemProperty('icon', 'diffusion')
         ->setMenuItemProperty('name', pht('Commits'))
         ->setMenuItemProperty('uri', $uri);
     }
 
-    $panels[] = $this->newPanel()
-      ->setBuiltinKey(self::PANEL_MANAGE)
-      ->setMenuItemKey(PhabricatorPeopleManageProfilePanel::PANELKEY);
+    $items[] = $this->newItem()
+      ->setBuiltinKey(self::ITEM_MANAGE)
+      ->setMenuItemKey(PhabricatorPeopleManageProfileMenuItem::MENUITEMKEY);
 
-    return $panels;
+    return $items;
   }
 
 }

src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php

@@ -1,11 +1,11 @@
 <?php
 
-final class PhabricatorPeopleDetailsProfilePanel
-  extends PhabricatorProfilePanel {
+final class PhabricatorPeopleDetailsProfileMenuItem
+  extends PhabricatorProfileMenuItem {
 
-  const PANELKEY = 'people.details';
+  const MENUITEMKEY = 'people.details';
 
-  public function getPanelTypeName() {
+  public function getMenuItemTypeName() {
     return pht('User Details');
   }
 

…PhabricatorPeopleDetailsProfilePanel.php …bricatorPeopleDetailsProfileMenuItem.phpsrc/applications/people/profilepanel/PhabricatorPeopleDetailsProfilePanel.php renamed to src/applications/people/menuitem/PhabricatorPeopleDetailsProfileMenuItem.php src/applications/people/profilepanel/PhabricatorPeopleDetailsProfilePanel.php renamed to src/applications/people/menuitem/PhabricatorPeopleDetailsProfileMenuItem.php

@@ -1,19 +1,19 @@
 <?php
 
-final class PhabricatorPeopleManageProfilePanel
-  extends PhabricatorProfilePanel {
+final class PhabricatorPeopleManageProfileMenuItem
+  extends PhabricatorProfileMenuItem {
 
-  const PANELKEY = 'people.manage';
+  const MENUITEMKEY = 'people.manage';
 
-  public function getPanelTypeName() {
+  public function getMenuItemTypeName() {
     return pht('Manage User');
   }
 
   private function getDefaultName() {
     return pht('Manage');
   }
 
-  public function canHidePanel(
+  public function canHideMenuItem(
     PhabricatorProfileMenuItemConfiguration $config) {
     return false;
   }