Add storage and read logic for workboard card cover photos

Summary:
No way to set photos yet, but if you magic them in they work.

Primarily, this consolidates rendering logic so the move + edit + view controllers all run the same code to do tags / cover photos.

Test Plan: {F1095870}

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15201

Author: epriestley

resources/sql/autopatches/20160206.cover.1.sql

@@ -0,0 +1,5 @@
+ALTER TABLE {$NAMESPACE}_maniphest.maniphest_task
+  ADD properties LONGTEXT NOT NULL COLLATE {$COLLATE_TEXT};
+
+UPDATE {$NAMESPACE}_maniphest.maniphest_task
+  SET properties = '{}' WHERE properties = '';

src/__phutil_library_map__.php

@@ -1815,6 +1815,7 @@
     'PhabricatorBinariesSetupCheck' => 'applications/config/check/PhabricatorBinariesSetupCheck.php',
     'PhabricatorBitbucketAuthProvider' => 'applications/auth/provider/PhabricatorBitbucketAuthProvider.php',
     'PhabricatorBoardLayoutEngine' => 'applications/project/engine/PhabricatorBoardLayoutEngine.php',
+    'PhabricatorBoardRenderingEngine' => 'applications/project/engine/PhabricatorBoardRenderingEngine.php',
     'PhabricatorBot' => 'infrastructure/daemon/bot/PhabricatorBot.php',
     'PhabricatorBotChannel' => 'infrastructure/daemon/bot/target/PhabricatorBotChannel.php',
     'PhabricatorBotDebugLogHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotDebugLogHandler.php',
@@ -6043,6 +6044,7 @@
     'PhabricatorBinariesSetupCheck' => 'PhabricatorSetupCheck',
     'PhabricatorBitbucketAuthProvider' => 'PhabricatorOAuth1AuthProvider',
     'PhabricatorBoardLayoutEngine' => 'Phobject',
+    'PhabricatorBoardRenderingEngine' => 'Phobject',
     'PhabricatorBot' => 'PhabricatorDaemon',
     'PhabricatorBotChannel' => 'PhabricatorBotTarget',
     'PhabricatorBotDebugLogHandler' => 'PhabricatorBotHandler',

src/applications/files/transform/PhabricatorFileThumbnailTransform.php

@@ -7,6 +7,7 @@ final class PhabricatorFileThumbnailTransform
   const TRANSFORM_PINBOARD = 'pinboard';
   const TRANSFORM_THUMBGRID = 'thumbgrid';
   const TRANSFORM_PREVIEW = 'preview';
+  const TRANSFORM_WORKCARD = 'workcard';
 
   private $name;
   private $key;
@@ -73,6 +74,10 @@ public function generateTransforms() {
         ->setName(pht('Preview (220px)'))
         ->setKey(self::TRANSFORM_PREVIEW)
         ->setDimensions(220, null),
+      id(new self())
+        ->setName(pht('Workcard (526px)'))
+        ->setKey(self::TRANSFORM_WORKCARD)
+        ->setDimensions(526, null),
     );
   }
 

src/applications/maniphest/editor/ManiphestEditEngine.php

@@ -334,39 +334,27 @@ private function buildCardResponse(ManiphestTask $task) {
       'sortMap' => $sort_map,
     );
 
-    // TODO: This should just use HandlePool once we get through the EditEngine
-    // transition.
-    $owner = null;
-    if ($task->getOwnerPHID()) {
-      $owner = id(new PhabricatorHandleQuery())
-        ->setViewer($viewer)
-        ->withPHIDs(array($task->getOwnerPHID()))
-        ->executeOne();
-    }
-
-    $handle_phids = $task->getProjectPHIDs();
-    $handle_phids = array_fuse($handle_phids);
-    $handle_phids = array_diff_key($handle_phids, $board_phids);
-
-    $project_handles = $viewer->loadHandles($handle_phids);
-    $project_handles = iterator_to_array($project_handles);
-
-    $tasks = id(new ProjectBoardTaskCard())
+    $rendering_engine = id(new PhabricatorBoardRenderingEngine())
       ->setViewer($viewer)
-      ->setTask($task)
-      ->setOwner($owner)
-      ->setProjectHandles($project_handles)
-      ->setCanEdit(true)
-      ->getItem();
+      ->setObjects(array($task))
+      ->setExcludedProjectPHIDs($board_phids);
 
-    $tasks->addClass('phui-workcard');
+    $card = $rendering_engine->renderCard($task->getPHID());
+
+    $item = $card->getItem();
+    $item->addClass('phui-workcard');
 
     $payload = array(
-      'tasks' => $tasks,
+      'tasks' => $item,
       'data' => $data,
     );
 
-    return id(new AphrontAjaxResponse())->setContent($payload);
+    return id(new AphrontAjaxResponse())
+      ->setContent(
+        array(
+          'tasks' => $item,
+          'data' => $data,
+        ));
   }
 
 

src/applications/maniphest/storage/ManiphestTask.php

@@ -38,6 +38,7 @@ final class ManiphestTask extends ManiphestDAO
 
   protected $ownerOrdering;
   protected $spacePHID;
+  protected $properties = array();
 
   private $subscriberPHIDs = self::ATTACHABLE;
   private $groupByProjectPHID = self::ATTACHABLE;
@@ -74,6 +75,7 @@ protected function getConfiguration() {
         'ccPHIDs' => self::SERIALIZATION_JSON,
         'attached' => self::SERIALIZATION_JSON,
         'projectPHIDs' => self::SERIALIZATION_JSON,
+        'properties' => self::SERIALIZATION_JSON,
       ),
       self::CONFIG_COLUMN_SCHEMA => array(
         'ownerPHID' => 'phid?',
@@ -215,6 +217,19 @@ public function getPrioritySortVector() {
     );
   }
 
+  public function setProperty($key, $value) {
+    $this->properties[$key] = $value;
+    return $this;
+  }
+
+  public function getProperty($key, $default = null) {
+    return idx($this->properties, $key, $default);
+  }
+
+  public function getCoverImageThumbnailPHID() {
+    return idx($this->properties, 'cover.thumbnailPHID');
+  }
+
 
 /* -(  PhabricatorSubscribableInterface  )----------------------------------- */
 

src/applications/project/controller/PhabricatorProjectBoardViewController.php

@@ -7,7 +7,6 @@ final class PhabricatorProjectBoardViewController
 
   private $id;
   private $slug;
-  private $handles;
   private $queryKey;
   private $filter;
   private $sortKey;
@@ -226,22 +225,9 @@ public function handleRequest(AphrontRequest $request) {
       'project-boards',
       $behavior_config);
 
-    $this->handles = ManiphestTaskListView::loadTaskHandles($viewer, $tasks);
-
-    $all_project_phids = array();
-    foreach ($tasks as $task) {
-      foreach ($task->getProjectPHIDs() as $project_phid) {
-        $all_project_phids[$project_phid] = $project_phid;
-      }
-    }
-
-    foreach ($select_phids as $phid) {
-      unset($all_project_phids[$phid]);
-    }
-
-    $all_handles = $viewer->loadHandles($all_project_phids);
-    $all_handles = iterator_to_array($all_handles);
-
+    $visible_columns = array();
+    $column_phids = array();
+    $visible_phids = array();
     foreach ($columns as $column) {
       if (!$this->showHidden) {
         if ($column->isHidden()) {
@@ -268,6 +254,25 @@ public function handleRequest(AphrontRequest $request) {
         $column_tasks = array_select_keys($column_tasks, array_keys($tasks));
       }
 
+      $column_phid = $column->getPHID();
+
+      $visible_columns[$column_phid] = $column;
+      $column_phids[$column_phid] = $column_tasks;
+
+      foreach ($column_tasks as $phid => $task) {
+        $visible_phids[$phid] = $phid;
+      }
+    }
+
+    $rendering_engine = id(new PhabricatorBoardRenderingEngine())
+      ->setViewer($viewer)
+      ->setObjects(array_select_keys($tasks, $visible_phids))
+      ->setEditMap($task_can_edit_map)
+      ->setExcludedProjectPHIDs($select_phids);
+
+    foreach ($visible_columns as $column_phid => $column) {
+      $column_tasks = $column_phids[$column_phid];
+
       $panel = id(new PHUIWorkpanelView())
         ->setHeader($column->getDisplayName())
         ->setSubHeader($column->getDisplayType())
@@ -317,22 +322,10 @@ public function handleRequest(AphrontRequest $request) {
           ));
 
       foreach ($column_tasks as $task) {
-        $owner = null;
-        if ($task->getOwnerPHID()) {
-          $owner = $this->handles[$task->getOwnerPHID()];
-        }
-        $can_edit = idx($task_can_edit_map, $task->getPHID(), false);
-
-        $handles = array_select_keys($all_handles, $task->getProjectPHIDs());
-
-        $cards->addItem(id(new ProjectBoardTaskCard())
-          ->setViewer($viewer)
-          ->setProjectHandles($handles)
-          ->setTask($task)
-          ->setOwner($owner)
-          ->setCanEdit($can_edit)
-          ->getItem());
+        $card = $rendering_engine->renderCard($task->getPHID());
+        $cards->addItem($card->getItem());
       }
+
       $panel->setCards($cards);
       $board->addPanel($panel);
     }

src/applications/project/controller/PhabricatorProjectMoveController.php

@@ -175,24 +175,11 @@ public function handleRequest(AphrontRequest $request) {
 
     $editor->applyTransactions($object, $xactions);
 
-    $owner = null;
-    if ($object->getOwnerPHID()) {
-      $owner = id(new PhabricatorHandleQuery())
-        ->setViewer($viewer)
-        ->withPHIDs(array($object->getOwnerPHID()))
-        ->executeOne();
-    }
-
     // Reload the object so it reflects edits which have been applied.
     $object = id(new ManiphestTaskQuery())
       ->setViewer($viewer)
       ->withPHIDs(array($object_phid))
       ->needProjectPHIDs(true)
-      ->requireCapabilities(
-        array(
-          PhabricatorPolicyCapability::CAN_VIEW,
-          PhabricatorPolicyCapability::CAN_EDIT,
-        ))
       ->executeOne();
 
     $except_phids = array($board_phid);
@@ -206,25 +193,21 @@ public function handleRequest(AphrontRequest $request) {
       }
     }
 
-    $except_phids = array_fuse($except_phids);
-    $handle_phids = array_fuse($object->getProjectPHIDs());
-    $handle_phids = array_diff_key($handle_phids, $except_phids);
-
-    $project_handles = $viewer->loadHandles($handle_phids);
-    $project_handles = iterator_to_array($project_handles);
-
-    $card = id(new ProjectBoardTaskCard())
+    $rendering_engine = id(new PhabricatorBoardRenderingEngine())
       ->setViewer($viewer)
-      ->setTask($object)
-      ->setOwner($owner)
-      ->setCanEdit(true)
-      ->setProjectHandles($project_handles)
-      ->getItem();
+      ->setObjects(array($object))
+      ->setExcludedProjectPHIDs($except_phids);
 
-    $card->addClass('phui-workcard');
+    $card = $rendering_engine->renderCard($object->getPHID());
 
-    return id(new AphrontAjaxResponse())->setContent(
-      array('task' => $card));
+    $item = $card->getItem();
+    $item->addClass('phui-workcard');
+
+    return id(new AphrontAjaxResponse())
+      ->setContent(
+        array(
+          'task' => $item,
+        ));
   }
 
 }