Maniphest Tasks + Project Boards - some polish

Summary:
Fixes T4550 by changing supportsFeed to shouldPublishFeedStory, so things can be more granular like that are with mail. Attempts to fix things generally too, filtering out xactions that have no business in feed, etc.

Also return an updated Task HTML representation on drag and drop moves, etc. This is important so if the priority changes you can see it reflected in the UI.

Test Plan: dragged tasks around. observed no feed stories on subpriority drags. observed feed stories and updated color bars on stories that changed priority

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4550

Differential Revision: https://secure.phabricator.com/D8399

Author: bobtrahan

src/applications/conpherence/editor/ConpherenceEditor.php

@@ -400,7 +400,9 @@ protected function getMailSubjectPrefix() {
     return PhabricatorEnv::getEnvConfig('metamta.conpherence.subject-prefix');
   }
 
-  protected function supportsFeed() {
+  protected function shouldPublishFeedStory(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return false;
   }
 

src/applications/differential/editor/DifferentialTransactionEditor.php

@@ -785,7 +785,9 @@ protected function requireCapabilities(
     return parent::requireCapabilities($object, $xaction);
   }
 
-  protected function supportsFeed() {
+  protected function shouldPublishFeedStory(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }
 

src/applications/files/editor/PhabricatorFileEditor.php

@@ -80,7 +80,9 @@ protected function buildMailBody(
     return $body;
   }
 
-  protected function supportsFeed() {
+  protected function shouldPublishFeedStory(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }
 

src/applications/legalpad/editor/LegalpadDocumentEditor.php

@@ -183,7 +183,9 @@ protected function getMailSubjectPrefix() {
   }
 
 
-  protected function supportsFeed() {
+  protected function shouldPublishFeedStory(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return false;
   }
 

src/applications/macro/editor/PhabricatorMacroEditor.php

@@ -156,7 +156,9 @@ protected function getMailSubjectPrefix() {
     return PhabricatorEnv::getEnvConfig('metamta.macro.subject-prefix');
   }
 
-  protected function supportsFeed() {
+  protected function shouldPublishFeedStory(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }
 }

src/applications/maniphest/editor/ManiphestTransactionEditor.php

@@ -251,19 +251,8 @@ protected function shouldSendMail(
     PhabricatorLiskDAO $object,
     array $xactions) {
 
-    $should_mail = true;
-    if (count($xactions) == 1) {
-      $xaction = head($xactions);
-      switch ($xaction->getTransactionType()) {
-        case ManiphestTransaction::TYPE_SUBPRIORITY:
-          $should_mail = false;
-          break;
-        default:
-          $should_mail = true;
-          break;
-      }
-    }
-    return $should_mail;
+    $xactions = mfilter($xactions, 'shouldHide', true);
+    return $xactions;
   }
 
   protected function getMailSubjectPrefix() {
@@ -318,8 +307,10 @@ protected function buildMailBody(
     return $body;
   }
 
-  protected function supportsFeed() {
-    return true;
+  protected function shouldPublishFeedStory(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
+    return $this->shouldSendMail($object, $xactions);
   }
 
   protected function supportsSearch() {

src/applications/maniphest/storage/ManiphestTransaction.php

@@ -109,7 +109,7 @@ public function shouldHide() {
         return true;
     }
 
-    return false;
+    return parent::shouldHide();
   }
 
   public function getActionStrength() {

src/applications/paste/editor/PhabricatorPasteEditor.php

@@ -157,7 +157,9 @@ protected function buildMailTemplate(PhabricatorLiskDAO $object) {
       ->addHeader('Thread-Topic', "P{$id}");
   }
 
-  protected function supportsFeed() {
+  protected function shouldPublishFeedStory(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }
 

src/applications/pholio/editor/PholioMockEditor.php

@@ -402,7 +402,9 @@ protected function getMailSubjectPrefix() {
     return PhabricatorEnv::getEnvConfig('metamta.pholio.subject-prefix');
   }
 
-  protected function supportsFeed() {
+  protected function shouldPublishFeedStory(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }
 

src/applications/ponder/editor/PonderEditor.php

@@ -3,7 +3,9 @@
 abstract class PonderEditor
   extends PhabricatorApplicationTransactionEditor {
 
-  protected function supportsFeed() {
+  protected function shouldPublishFeedStory(
+    PhabricatorLiskDAO $object,
+    array $xactions) {
     return true;
   }